improvement(useLocalStorage): Always return string from useLocalStorage serializer

Author: microcipcip

src/components/useCookie/useCookie.spec.ts

@@ -126,7 +126,7 @@ describe('useCookie', () => {
     )
   })
 
-  it('should correctly set using the serializer', async () => {
+  it('should correctly set the object using the serializer', async () => {
     const cookieName = 'cookieName'
     const cookieValue = { value1: 'testValue1', value2: 'testValue2' }
     const serializerVal = { value1: 'testValue1+1', value2: 'testValue2+1' }
@@ -154,11 +154,10 @@ describe('useCookie', () => {
     const wrapper = mount(
       testComponent(cookieName, cookieValue, {
         isParsing: false,
-        serializer: (obj: any) =>
-          JSON.stringify({
-            value1: `${obj.value1}+1`,
-            value2: `${obj.value2}+1`
-          })
+        serializer: (obj: any) => ({
+          value1: `${obj.value1}+1`,
+          value2: `${obj.value2}+1`
+        })
       })
     )
     wrapper.find('#setCookie').trigger('click')

src/components/useLocalStorage/useLocalStorage.spec.ts

@@ -144,7 +144,7 @@ describe('useItem', () => {
     )
   })
 
-  it('should correctly set using the serializer', async () => {
+  it('should correctly set the object using the serializer', async () => {
     const itemKey = 'itemKey'
     const itemValue = { value1: 'testValue1', value2: 'testValue2' }
     const serializerVal = { value1: 'testValue1+1', value2: 'testValue2+1' }
@@ -172,11 +172,10 @@ describe('useItem', () => {
     const wrapper = mount(
       testComponent(itemKey, itemValue, {
         isParsing: false,
-        serializer: (obj: any) =>
-          JSON.stringify({
-            value1: `${obj.value1}+1`,
-            value2: `${obj.value2}+1`
-          })
+        serializer: (obj: any) => ({
+          value1: `${obj.value1}+1`,
+          value2: `${obj.value2}+1`
+        })
       })
     )
     wrapper.find('#setItem').trigger('click')

src/utils.ts

@@ -1,6 +1,9 @@
 const checkType = (typeToCheck: any) =>
   Object.prototype.toString.call(typeToCheck)
 
+export const isString = (varToCheck: any) =>
+  checkType(varToCheck) === '[object String]'
+
 export const isObj = (varToCheck: any) =>
   checkType(varToCheck) === '[object Object]'
 
@@ -47,16 +50,17 @@ export const createSerializer = (serializer?: Function) =>
 export const createDeserializer = (deserializer?: Function) =>
   deserializer || JSON.parse
 
+const fallbackToString = (val: any) => (isString(val) ? val : String(val))
 export const trySerialize = (
   val: any,
   serializer: Function,
   shouldSerialize?: boolean
 ) => {
-  if (!shouldSerialize) return String(val)
+  if (!shouldSerialize) return fallbackToString(val)
   try {
-    return serializer(val)
+    return fallbackToString(serializer(val))
   } catch (error) {
-    return val
+    return fallbackToString(val)
   }
 }