fix: resolve SonarQube code quality issues

- Replace custom ApplicationJsonMediaType with standard MediaTypeNames.Application.Json
- Make ConfigurationConstants class static
- Add 'out' keyword to generic parameter for covariance in IArtifactAndSnapshotManager
- Make ExtractOperationName method static in MicrocksAsyncMinionContainer
- Use nameof() in ArgumentNullException parameter in SecretBuilder
- Fix _microcksImage field usage in MicrocksBuilder.Init()
- Exclude HTTP localhost URLs in test containers from HTTPS warning (S5332)

Signed-off-by: SebastienDegodez <sebastien.degodez@gmail.com>

Author: SebastienDegodez

src/Microcks.Testcontainers/Helpers/ConfigurationConstants.cs

@@ -20,7 +20,7 @@ namespace Microcks.Testcontainers.Helpers;
 /// <summary>
 /// Configuration constants for Microcks Testcontainers.
 /// </summary>
-public class ConfigurationConstants
+public static class ConfigurationConstants
 {
     /// <summary>
     /// Environment variable name used to configure Microcks logging level for the Microcks package.

src/Microcks.Testcontainers/IArtifactAndSnapshotManager.cs

@@ -20,7 +20,7 @@ namespace Microcks.Testcontainers;
 /// <summary>
 /// Artifacts management interface for fluent approach.
 /// </summary>
-public interface IArtifactAndSnapshotManager<T>
+public interface IArtifactAndSnapshotManager<out T>
 {
     /// <summary>
     /// Add main/primary artifacts.

src/Microcks.Testcontainers/MicrocksAsyncMinionContainer.cs

@@ -68,7 +68,7 @@ public Uri GetWebSocketMockEndpoint(string service, string version, string opera
     /// </summary>
     /// <param name="operationName">operationName may start with SUBSCRIBE or PUBLISH.</param>
     /// <returns>The extracted operation name.</returns>
-    private string ExtractOperationName(string operationName)
+    private static string ExtractOperationName(string operationName)
     {
         if (operationName.Contains(' '))
         {

src/Microcks.Testcontainers/MicrocksBuilder.cs

@@ -31,7 +31,7 @@ public sealed class MicrocksBuilder : ContainerBuilder<MicrocksBuilder, Microcks
     /// <summary>
     /// Image name for the Microcks container.
     /// </summary>
-    private string _microcksImage = MicrocksImage;
+    private readonly string _microcksImage = MicrocksImage;
 
     /// <summary>
     /// HTTP port for the Microcks container.
@@ -136,7 +136,7 @@ protected override MicrocksBuilder Init()
     {
         return base.Init()
             .WithEnvironment(MacOSHelper.GetJavaOptions())
-            .WithImage(MicrocksImage)
+            .WithImage(_microcksImage)
             .WithPortBinding(MicrocksHttpPort, true)
             .WithPortBinding(MicrocksGrpcPort, true)
             .WithWaitStrategy(Wait.ForUnixContainer().UntilMessageIsLogged(".*Started MicrocksApplication.*"));

src/Microcks.Testcontainers/MicrocksContainerEnsemble.cs

@@ -86,9 +86,13 @@ public MicrocksContainerEnsemble(INetwork network, string microcksImage)
             .WithExposedPort(MicrocksBuilder.MicrocksHttpPort)
             .WithExposedPort(MicrocksBuilder.MicrocksGrpcPort)
             .WithEnvironment(MacOSHelper.GetJavaOptions())
+            // HTTP is used intentionally for container-to-container communication in unit/integration tests
+            // This is localhost communication within a test environment, not production traffic
+#pragma warning disable S5332 // Using http protocol is insecure. Use https instead
             .WithEnvironment("POSTMAN_RUNNER_URL", "http://postman:3000")
             .WithEnvironment("TEST_CALLBACK_URL", "http://microcks:" + MicrocksBuilder.MicrocksHttpPort)
             .WithEnvironment("ASYNC_MINION_URL", "http://microcks-async-minion:" + MicrocksAsyncMinionBuilder.MicrocksAsyncMinionHttpPort);
+#pragma warning restore S5332 // Using http protocol is insecure. Use https instead
     }
 
     /// <summary>

src/Microcks.Testcontainers/MicrocksContainerExtensions.cs

@@ -21,6 +21,7 @@
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Net.Http.Json;
+using System.Net.Mime;
 using System.Text;
 using System.Text.Json;
 using System.Threading;
@@ -34,7 +35,6 @@ namespace Microcks.Testcontainers;
 /// </summary>
 public static class MicrocksContainerExtensions
 {
-
     private static string _metricsAPIDatePattern = "yyyyMMdd";
 
     /// <summary>
@@ -45,7 +45,7 @@ public static class MicrocksContainerExtensions
     {
         DefaultRequestHeaders =
         {
-            Accept = { MediaTypeWithQualityHeaderValue.Parse("application/json") },
+            Accept = { MediaTypeWithQualityHeaderValue.Parse(MediaTypeNames.Application.Json) },
             CacheControl = CacheControlHeaderValue.Parse("no-cache")
         }
     });
@@ -64,7 +64,7 @@ public static async Task<TestResult> TestEndpointAsync(
         this MicrocksContainer container, TestRequest testRequest, CancellationToken cancellationToken = default)
     {
         string httpEndpoint = container.GetHttpEndpoint() + "api/tests";
-        var content = new StringContent(JsonSerializer.Serialize(testRequest), Encoding.UTF8, "application/json");
+        var content = new StringContent(JsonSerializer.Serialize(testRequest), Encoding.UTF8, MediaTypeNames.Application.Json);
         var responseMessage = await Client.PostAsync(httpEndpoint, content, cancellationToken);
 
         if (responseMessage.StatusCode == HttpStatusCode.Created)

src/Microcks.Testcontainers/Model/SecretBuilder.cs

@@ -76,7 +76,7 @@ public Secret Build()
     {
         if (_name == null)
         {
-            throw new ArgumentNullException("Name is required");
+            throw new ArgumentNullException(nameof(_name), "Name is required");
         }
 
         return new Secret()