fix: #223 Fail in case not a success (failure or in progress) and no report on test results

Signed-off-by: Laurent Broudoux <[email protected]>

Author: lbroudoux

src/main/java/io/github/microcks/testcontainers/Assertions.java

@@ -41,6 +41,7 @@ public static void assertSuccess(TestResult testResult) {
          if (!failures.isEmpty()) {
             throw new MultipleFailuresError("Test '" + testResult.getId() + "' has failed", failures);
          }
+         throw new AssertionFailedError("Test '" + testResult.getId() + "' is not a success, but has no failure details");
       }
    }
 

src/test/java/io/github/microcks/testcontainers/AssertionsTest.java

@@ -148,4 +148,36 @@ void testPartialFailure() {
          fail("An AssertionFailedError should have been thrown");
       }
    }
+
+   @Test
+   void testFailureWithEmptyCases() {
+      TestResult result = new TestResult();
+      result.setId("testFailureWithEmptyCases");
+      result.setSuccess(false);
+      result.setTestCaseResults(List.of());
+
+      boolean failed = false;
+      try {
+         Assertions.assertSuccess(result);
+      } catch (Error error) {
+         failed = true;
+         assertInstanceOf(AssertionFailedError.class, error);
+         assertEquals("Test 'testFailureWithEmptyCases' is not a success, but has no failure details", error.getMessage());
+      }
+      if (!failed) {
+         fail("An AssertionFailedError should have been thrown");
+      }
+
+      failed = false;
+      try {
+         Assertions.assertSuccess(result, "op1");
+      } catch (Error error) {
+         failed = true;
+         assertInstanceOf(AssertionFailedError.class, error);
+         assertEquals("Test 'testFailureWithEmptyCases' has no test case for operation 'op1'", error.getMessage());
+      }
+      if (!failed) {
+         fail("An AssertionFailedError should have been thrown");
+      }
+   }
 }

src/test/java/io/github/microcks/testcontainers/MicrocksContainerTest.java

@@ -318,9 +318,9 @@ private void testMicrocksContractTestingFunctionality(MicrocksContainer microcks
       // First test should fail with validation failure messages.
       TestResult testResult = microcks.testEndpoint(testRequest);
 
-      System.err.println(microcks.getLogs());
-      ObjectMapper mapper = new ObjectMapper().setSerializationInclusion(JsonInclude.Include.NON_NULL);
-      System.out.println(mapper.writerWithDefaultPrettyPrinter().writeValueAsString(testResult));
+//      System.err.println(microcks.getLogs());
+//      ObjectMapper mapper = new ObjectMapper().setSerializationInclusion(JsonInclude.Include.NON_NULL);
+//      System.out.println(mapper.writerWithDefaultPrettyPrinter().writeValueAsString(testResult));
 
       assertFalse(testResult.isSuccess());
       assertEquals("http://bad-impl:3001", testResult.getTestedEndpoint());