Skip to content

Commit 359a760

Browse files
eharris369GitHub Enterprise
authored andcommitted
Merge pull request #224 from eharris/200-cleanUpSourceCode
Issue #200: Clean up the source code before open sourcing
2 parents edebba5 + a5f7378 commit 359a760

File tree

8 files changed

+3
-17
lines changed

8 files changed

+3
-17
lines changed

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/HttpUtil.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ public static HttpResult get(URI uri) throws IOException {
8383

8484
try {
8585
connection = (HttpURLConnection) uri.toURL().openConnection();
86-
// MCLogger.log("GET " + url);
8786

8887
connection.setRequestMethod("GET");
8988
connection.setReadTimeout(5000);

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/MCLogger.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
*/
2323
public class MCLogger implements DebugOptionsListener {
2424

25-
// private static final SimpleDateFormat TIME_SDF = new SimpleDateFormat("k:mm:ss");
26-
2725
private static final ILog logger = MicroclimateCorePlugin.getDefault().getLog();
2826

2927
private static MCLogger instance;

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/MicroclimateApplication.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@
99

1010
package com.ibm.microclimate.core.internal;
1111

12-
import java.io.IOException;
1312
import java.net.MalformedURLException;
1413
import java.net.URL;
1514

1615
import org.eclipse.core.runtime.IPath;
17-
import org.json.JSONException;
1816
import org.json.JSONObject;
1917

2018
import com.ibm.microclimate.core.internal.connection.MicroclimateConnection;
@@ -125,8 +123,6 @@ public synchronized void setAction(String action) {
125123
this.action = action;
126124
}
127125

128-
// Getters for our project state fields
129-
130126
/**
131127
* Can return null if this project hasn't started yet (ie httpPort == -1)
132128
*/

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/MicroclimateApplicationFactory.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ public static MicroclimateApplication createApp(MicroclimateConnection mcConnect
8181
try {
8282
// from portal: projectType and buildType are equivalent - however
8383
// buildType is always present, projectType is missing for disabled/stopped projects
84-
// We should use projectType if it gets fixed
85-
// see see https://github.ibm.com/dev-ex/portal/issues/520
84+
// We should use projectType if it gets fixed.
8685
// String typeStr = appJso.getString(MCConstants.KEY_PROJECT_TYPE);
8786

8887
String typeStr = appJso.getString(MCConstants.KEY_BUILD_TYPE);

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/connection/MicroclimateSocket.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import io.socket.emitter.Emitter;
3535

3636
/**
37-
* Wrapper for a SocketIO client socket, which connects to FileWatcher and listens for project state changes,
37+
* Wrapper for a SocketIO client socket, which connects to Microclimate and listens for project state changes,
3838
* then updates the corresponding MicroclimateApplication's state.
3939
* One of these exists for each MicroclimateConnection. That connection is stored here so we can access
4040
* its applications.

dev/com.ibm.microclimate.ui/src/com/ibm/microclimate/ui/internal/actions/CreateConnectionAction.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
*/
3535
public class CreateConnectionAction extends Action implements IViewActionDelegate, IActionDelegate2 {
3636

37-
private Shell shell;
38-
3937
public CreateConnectionAction(Shell shell) {
4038
super(Messages.ActionNewConnection);
4139
setImageDescriptor(MicroclimateUIPlugin.getImageDescriptor(MicroclimateUIPlugin.MICROCLIMATE_ICON));

dev/com.ibm.microclimate.ui/src/com/ibm/microclimate/ui/internal/actions/ImportProjectAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import org.eclipse.core.resources.IProject;
1313
import org.eclipse.core.resources.ResourcesPlugin;
1414
import org.eclipse.core.runtime.IPath;
15-
import org.eclipse.core.runtime.jobs.Job;
1615
import org.eclipse.jface.action.IAction;
1716
import org.eclipse.jface.viewers.ISelection;
1817
import org.eclipse.jface.viewers.IStructuredSelection;
@@ -30,6 +29,7 @@
3029
* Action for importing a Microclimate project into Eclipse. This makes
3130
* the source available for editing and debugging.
3231
*/
32+
@SuppressWarnings("restriction")
3333
public class ImportProjectAction implements IObjectActionDelegate {
3434

3535
protected MicroclimateApplication app;

dev/com.ibm.microclimate.ui/src/com/ibm/microclimate/ui/internal/actions/RestartDebugModeAction.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
import org.eclipse.core.runtime.IStatus;
1717
import org.eclipse.core.runtime.Status;
1818
import org.eclipse.core.runtime.jobs.Job;
19-
import org.eclipse.debug.core.DebugPlugin;
20-
import org.eclipse.debug.core.ILaunch;
21-
import org.eclipse.debug.core.ILaunchManager;
22-
import org.eclipse.debug.core.model.IDebugTarget;
2319
import org.eclipse.jface.action.IAction;
2420
import org.eclipse.jface.dialogs.MessageDialog;
2521
import org.eclipse.jface.viewers.ISelection;

0 commit comments

Comments
 (0)