Issue #99: Fix post project creation issues

Author: eharris369

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/MicroclimateApplication.java

@@ -13,6 +13,7 @@
 
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.util.Collections;
 import java.util.List;
 
 import org.eclipse.core.runtime.IPath;
@@ -47,7 +48,7 @@ public class MicroclimateApplication {
 	private String containerId;
 	private ProjectCapabilities projectCapabilities;
 	private String action;
-	private List<ProjectLogInfo> logInfos;
+	private List<ProjectLogInfo> logInfos = Collections.emptyList();
 	private boolean metricsAvailable = false;
 
 	// Must be updated whenever httpPort changes. Can be null

dev/com.ibm.microclimate.core/src/com/ibm/microclimate/core/internal/connection/MicroclimateSocket.java

@@ -280,11 +280,11 @@ private void onProjectCreation(JSONObject event) throws JSONException {
 		String projectID = event.getString(MCConstants.KEY_PROJECT_ID);
 		mcConnection.refreshApps(projectID);
 		MicroclimateApplication app = mcConnection.getAppByID(projectID);
-		if (app == null) {
+		if (app != null) {
+			app.setEnabled(true);
+		} else {
 			MCLogger.logError("No application found matching the project id for the project creation event: " + projectID); //$NON-NLS-1$
-			return;
 		}
-		app.setEnabled(true);
 		MCUtil.updateConnection(mcConnection);
 	}
 

dev/com.ibm.microclimate.ui/src/com/ibm/microclimate/ui/internal/actions/HideAllLogsAction.java

@@ -38,23 +38,30 @@ public void setApp(MCEclipseApplication app) {
 
     	// Only enable if there is at least one log file that has a console
         boolean enabled = false;
-    	for (ProjectLogInfo logInfo : app.getLogInfos()) {
-    		if (app.getConsole(logInfo) != null) {
-    			enabled = true;
-    			break;
-    		}
-    	}
+        if (app.getLogInfos() != null && !app.getLogInfos().isEmpty()) {
+	    	for (ProjectLogInfo logInfo : app.getLogInfos()) {
+	    		if (app.getConsole(logInfo) != null) {
+	    			enabled = true;
+	    			break;
+	    		}
+	    	}
+        }
     	setEnabled(enabled);
     }
 
     @Override
     public void run() {
         if (app == null) {
         	// should not be possible
-        	MCLogger.logError("ToggleConsolesAction ran but no Microclimate application was selected");
+        	MCLogger.logError("HideAllLogsAction ran but no Microclimate application was selected");
 			return;
 		}
 
+        if (app.getLogInfos() == null || app.getLogInfos().isEmpty()) {
+        	MCLogger.logError("HideAllLogsAction ran but there are no logs for the selected application: " + app.name);
+        	return;
+        }
+        
         // Remove any existing consoles for this app
         for (ProjectLogInfo logInfo : app.getLogInfos()) {
         	SocketConsole console = app.getConsole(logInfo);

dev/com.ibm.microclimate.ui/src/com/ibm/microclimate/ui/internal/actions/LogFileActionProvider.java

@@ -60,7 +60,7 @@ public void fillContextMenu(IMenuManager menu) {
         	if (obj instanceof MCEclipseApplication) {
         		final MCEclipseApplication app = (MCEclipseApplication)obj;
         		if (app.mcConnection.checkVersion(1905, "2019_M5_E")) {
-        			if (app.isAvailable() && app.getLogInfos().size() > 0) {
+        			if (app.isAvailable() && app.getLogInfos() != null && !app.getLogInfos().isEmpty()) {
         				MenuManager menuMgr = new MenuManager(Messages.ShowLogFilesMenu, "ShowLogFiles");
         				showAllLogsAction.setApp(app);
         				menuMgr.add(showAllLogsAction);

dev/com.ibm.microclimate.ui/src/com/ibm/microclimate/ui/internal/actions/ShowAllLogsAction.java

@@ -37,11 +37,13 @@ public void setApp(MCEclipseApplication app) {
 
     	// Only enable if there is a log file that does not currently have a console
     	boolean enabled = false;
-    	for (ProjectLogInfo logInfo : app.getLogInfos()) {
-    		if (app.getConsole(logInfo) == null) {
-    			enabled = true;
-    			break;
-    		}
+    	if (app.getLogInfos() != null && !app.getLogInfos().isEmpty()) {
+	    	for (ProjectLogInfo logInfo : app.getLogInfos()) {
+	    		if (app.getConsole(logInfo) == null) {
+	    			enabled = true;
+	    			break;
+	    		}
+	    	}
     	}
     	setEnabled(enabled);
     }
@@ -50,10 +52,15 @@ public void setApp(MCEclipseApplication app) {
     public void run() {
         if (app == null) {
         	// should not be possible
-        	MCLogger.logError("ToggleConsolesAction ran but no Microclimate application was selected");
+        	MCLogger.logError("ShowAllLogsAction ran but no Microclimate application was selected");
 			return;
 		}
 
+        if (app.getLogInfos() == null || app.getLogInfos().isEmpty()) {
+        	MCLogger.logError("ShowAllLogsAction ran but there are no logs for the selected application: " + app.name);
+        	return;
+        }
+        
         // Create consoles for any log files that don't have one yet
         for (ProjectLogInfo logInfo : app.getLogInfos()) {
     		if (app.getConsole(logInfo) == null) {