Skip to content

Commit 4792b13

Browse files
author
Tim Etchells
committed
remove show-on-change settings
fixes #41
1 parent 5c72f6e commit 4792b13

File tree

3 files changed

+3
-30
lines changed

3 files changed

+3
-30
lines changed

dev/package.json

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,6 @@
3636
},
3737
"icon": "res/img/microclimate.png",
3838
"contributes": {
39-
"configuration": {
40-
"type": "object",
41-
"title": "Microclimate Tools",
42-
"properties": {
43-
"microclimate.openLogsOnChange.app": {
44-
"type": "boolean",
45-
"default": false,
46-
"description": "%settingDesc_showLogOnChange_app%"
47-
},
48-
"microclimate.openLogsOnChange.build": {
49-
"type": "boolean",
50-
"default": true,
51-
"description": "%settingDesc_showLogOnChange_build%"
52-
}
53-
}
54-
},
5539
"views": {
5640
"explorer": [
5741
{

dev/src/constants/Settings.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ enum Settings {
1717
CONFIG_SECTION = "microclimate",
1818
CONNECTIONS_KEY = "connections",
1919

20-
OPEN_ON_CHANGE_APP = "openLogsOnChange.app",
21-
OPEN_ON_CHANGE_BUILD = "openLogsOnChange.build"
20+
// OPEN_ON_CHANGE_APP = "openLogsOnChange.app",
21+
// OPEN_ON_CHANGE_BUILD = "openLogsOnChange.build"
2222
}
2323

2424
export default Settings;

dev/src/microclimate/project/logs/deprecated/MCLog-Old.ts

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import * as vscode from "vscode";
1313

1414
import Log from "../../../../Logger";
15-
import Settings from "../../../../constants/Settings";
1615
import StringNamespaces from "../../../../constants/strings/StringNamespaces";
1716
import Translator from "../../../../constants/strings/translator";
1817

@@ -87,18 +86,8 @@ export class MCLogOld implements vscode.QuickPickItem {
8786
}
8887
}
8988

90-
/**
91-
* Call this whenever this log gets updated. It will show the log if the user has that preference set.
92-
*/
9389
protected onChange(): void {
94-
const setting: string = this.logType === MCLogOld.LogTypes.APP ? Settings.OPEN_ON_CHANGE_APP : Settings.OPEN_ON_CHANGE_BUILD;
95-
96-
const showOnChange: boolean = vscode.workspace.getConfiguration(Settings.CONFIG_SECTION)
97-
.get(setting, false);
98-
99-
if (showOnChange) {
100-
this.showOutputChannel();
101-
}
90+
// nothing now
10291
}
10392
}
10493

0 commit comments

Comments
 (0)