small fixes

- fix open folder on connection
- only activate codewind if necessary
- show error message from failed installer start ccmd

Author: Tim Etchells

dev/package.nls.json

@@ -87,7 +87,7 @@
     ],
 
     "isInViewWithNothingSelected": "view == ext.cw.explorer && !viewItem",
-    "isConnection": "viewItem =~ /ext\\.cw.\\.connection\\.(connected|disconnected)/",
+    "isConnection": "viewItem =~ /ext\\.cw\\.connection\\.(connected|disconnected)/",
     "isActiveConnection": "viewItem == ext.cw.connection.connected",
     "isInactiveConnection": "viewItem == ext.cw.connection.disconnected",
     "isConnectingConnection": "viewItem == ext.cw.connection.connecting",

dev/src/command/ActivateConnectionCmd.ts

@@ -80,12 +80,17 @@ async function tryAddConnection(connInfo: MCUtil.IConnectionInfo): Promise<Conne
 
     let envData: MCEnvironment.IMCEnvData;
     try {
-        await InstallerWrapper.start();
-        envData = await MCEnvironment.getEnvData(url);
+        try {
+            envData = await MCEnvironment.getEnvData(url);
+        }
+        catch (err) {
+            await InstallerWrapper.start();
+            envData = await MCEnvironment.getEnvData(url);
+        }
     }
     catch (err) {
         Log.e("Failed to contact codewind", err);
-        vscode.window.showErrorMessage("Failed to start Codewind. You can try starting it manually using the installer.");
+        vscode.window.showErrorMessage("Failed to start Codewind: " + MCUtil.errToString(err));
         return undefined;
     }
 

dev/src/view/ProjectTree.ts

@@ -34,9 +34,9 @@ export default class ProjectTreeDataProvider implements vscode.TreeDataProvider<
         ConnectionManager.instance.addOnChangeListener(this.refresh);
         Log.d("Finished constructing ProjectTree");
 
-        this.treeView.onDidChangeSelection((e) => {
-            Log.d("Selection is now", e.selection[0]);
-        });
+        // this.treeView.onDidChangeSelection((e) => {
+        //     Log.d("Selection is now", e.selection[0]);
+        // });
     }
 
     /**

dev/src/view/TreeItemFactory.ts

@@ -159,7 +159,9 @@ function getConnectionContext(connection: Connection): string {
     else {
         contextValue = TreeContextValues.CONN_DISCONNECTED;
     }
-    return buildContextValue([contextValue]);
+    const cv = buildContextValue([contextValue]);
+    // Log.d(`The context value for ${connection} is ${cv}`);
+    return cv;
 }
 
 function getProjectContext(project: Project): string {