remove workspace check from envMatches

Tim Etchells · Tim Etchells · commit f2cd3b2aa1c5 · 2019-01-22T17:07:20.000-05:00
diff --git a/dev/src/microclimate/connection/MCEnvironment.ts b/dev/src/microclimate/connection/MCEnvironment.ts
@@ -113,8 +113,8 @@ namespace MCEnvironment {
             return false;
         }
 
-        return connection.version === newVersionNumber &&
-            connection.workspacePath.fsPath === envData.workspace_location;
+        return connection.version === newVersionNumber;
+            // should check workspace too, but need to consider platform when comparing paths
             // more to check once we support ICP
             // envData.user_string
     }

Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,8 @@ namespace MCEnvironment {`
`113`	`113`	`return false;`
`114`	`114`	`}`
`115`	`115`
`116`		`- return connection.version === newVersionNumber &&`
`117`		`- connection.workspacePath.fsPath === envData.workspace_location;`
	`116`	`+ return connection.version === newVersionNumber;`
	`117`	`+ // should check workspace too, but need to consider platform when comparing paths`
`118`	`118`	`// more to check once we support ICP`
`119`	`119`	`// envData.user_string`
`120`	`120`	`}`