Fix: TOCTOU race condition in WearableSettingsActivity

SBALAVIGNESH123 · SBALAVIGNESH123 · commit ece85ec90679 · 2025-12-11T07:41:09.000+05:30
diff --git a/play-services-wearable/core/src/main/java/org/microg/gms/wearable/WearableSettingsActivity.java b/play-services-wearable/core/src/main/java/org/microg/gms/wearable/WearableSettingsActivity.java
@@ -51,8 +51,9 @@ private void refreshList() {
         }
 
         Set<String> connectedNodes = null;
-        if (WearableService.impl != null) {
-            connectedNodes = WearableService.impl.getConnectedNodes();
+        WearableImpl service = WearableService.impl;
+        if (service != null) {
+            connectedNodes = service.getConnectedNodes();
         }
 
         for (BluetoothDevice device : bondedDevices) {

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,9 @@ private void refreshList() {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`Set<String> connectedNodes = null;`
`54`		`- if (WearableService.impl != null) {`
`55`		`- connectedNodes = WearableService.impl.getConnectedNodes();`
	`54`	`+ WearableImpl service = WearableService.impl;`
	`55`	`+ if (service != null) {`
	`56`	`+ connectedNodes = service.getConnectedNodes();`
`56`	`57`	`}`
`57`	`58`
`58`	`59`	`for (BluetoothDevice device : bondedDevices) {`