Skip to content

Commit 5af949c

Browse files
Fixed not great cloning directory
1 parent f2eb147 commit 5af949c

File tree

3 files changed

+24
-12
lines changed

3 files changed

+24
-12
lines changed

src/main/java/io/micrometer/release/train/Git.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,11 @@
1414
package io.micrometer.release.train;
1515

1616
import io.micrometer.release.common.ProcessRunner;
17-
18-
import java.io.File;
19-
2017
import org.slf4j.Logger;
2118
import org.slf4j.LoggerFactory;
2219

20+
import java.io.File;
21+
2322
class Git {
2423

2524
private static final Logger log = LoggerFactory.getLogger(Git.class);
@@ -37,13 +36,15 @@ void changeTag(String tag) {
3736
}
3837

3938
File cloneRepo(String branch, String orgRepository) {
40-
log.info("Cloning out {} branch to folder {}", branch, branch);
41-
processRunner.run("gh", "repo", "clone", orgRepository, branch, "--", "-b", branch, "--single-branch");
42-
return clonedDir(branch);
39+
// micrometer-metrics/micrometer -> micrometer-metrics_micrometer
40+
String folderToCloneTo = orgRepository.replace("/", "_");
41+
log.info("Cloning out {} branch to folder {}", branch, folderToCloneTo);
42+
processRunner.run("gh", "repo", "clone", orgRepository, folderToCloneTo, "--", "-b", branch, "--single-branch");
43+
return clonedDir(folderToCloneTo);
4344
}
4445

45-
File clonedDir(String branch) {
46-
return new File(branch);
46+
File clonedDir(String subfolder) {
47+
return new File(subfolder);
4748
}
4849

4950
}

src/main/java/io/micrometer/release/train/TrainOptions.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,9 @@ private static boolean hasText(String contextPropagationVersions) {
171171

172172
enum ProjectDefinition {
173173

174-
TEST("gh-actions-test", "micrometer-bom"), CONTEXT_PROPAGATION("context-propagation", "context-propagation"),
175-
MICROMETER("micrometer", "micrometer-bom"), TRACING("tracing", "micrometer-tracing-bom"),
176-
DOC_GEN("micrometer-docs-generator", "micrometer-docs-generator");
174+
TEST("gh-actions-test", "micrometer-bom"), TRACING_TEST("gh-actions-test2", "micrometer-tracing-bom"),
175+
CONTEXT_PROPAGATION("context-propagation", "context-propagation"), MICROMETER("micrometer", "micrometer-bom"),
176+
TRACING("tracing", "micrometer-tracing-bom"), DOC_GEN("micrometer-docs-generator", "micrometer-docs-generator");
177177

178178
private final String groupId = "io.micrometer";
179179

@@ -182,7 +182,7 @@ enum ProjectDefinition {
182182
private final String artifactId;
183183

184184
ProjectDefinition(String repository, String artifactId) {
185-
this.orgRepo = repository.equals("gh-actions-test") ? "marcingrzejszczak/" + repository
185+
this.orgRepo = repository.contains("gh-actions-test") ? "marcingrzejszczak/" + repository
186186
: "micrometer-metrics/" + repository;
187187
this.artifactId = artifactId;
188188
}

src/test/java/io/micrometer/release/train/GitTests.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,15 @@ void should_checkout_tag() {
3333
then(processRunner).should().run("git", "checkout", "FETCH_HEAD");
3434
}
3535

36+
@Test
37+
void should_clone_a_repo() {
38+
Git git = new Git(processRunner);
39+
40+
git.cloneRepo("foo", "micrometer-metrics/micrometer");
41+
42+
then(processRunner).should()
43+
.run("gh", "repo", "clone", "micrometer-metrics/micrometer", "micrometer-metrics_micrometer", "--", "-b",
44+
"foo", "--single-branch");
45+
}
46+
3647
}

0 commit comments

Comments
 (0)