Skip to content

Commit 12e6c89

Browse files
authored
Resolve MissingOverride warnings from Error Prone (#6143)
Signed-off-by: Johnny Lim <[email protected]>
1 parent 80e2400 commit 12e6c89

File tree

14 files changed

+24
-0
lines changed

14 files changed

+24
-0
lines changed

implementations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,15 @@ public interface ElasticConfig extends StepRegistryConfig {
4444
* @param key Key to look up in the config.
4545
* @return Value for the key or null if no key is present.
4646
*/
47+
@Override
4748
@Nullable
4849
String get(String key);
4950

5051
/**
5152
* Property prefix to prepend to configuration names.
5253
* @return property prefix
5354
*/
55+
@Override
5456
default String prefix() {
5557
return "elastic";
5658
}

implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaConfig.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,14 @@ public interface GangliaConfig extends StepRegistryConfig {
4242
* @param key Key to lookup in the config.
4343
* @return Value for the key or null if no key is present.
4444
*/
45+
@Override
4546
@Nullable
4647
String get(String key);
4748

4849
/**
4950
* @return Property prefix to prepend to configuration names.
5051
*/
52+
@Override
5153
default String prefix() {
5254
return "ganglia";
5355
}
@@ -98,6 +100,7 @@ default int port() {
98100
/**
99101
* @return {@code true} if publishing is enabled. Default is {@code true}.
100102
*/
103+
@Override
101104
default boolean enabled() {
102105
return getBoolean(this, "enabled").orElse(true);
103106
}

implementations/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,14 @@ public interface GraphiteConfig extends DropwizardConfig {
4141
* @param key Key to lookup in the config.
4242
* @return Value for the key or null if no key is present.
4343
*/
44+
@Override
4445
@Nullable
4546
String get(String key);
4647

4748
/**
4849
* @return Property prefix to prepend to configuration names.
4950
*/
51+
@Override
5052
default String prefix() {
5153
return "graphite";
5254
}

implementations/micrometer-registry-health/src/main/java/io/micrometer/health/ServiceLevelObjective.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,7 @@ static class Instant extends NumericQuery {
481481
this.toValue = toValue;
482482
}
483483

484+
@Override
484485
protected Double getValue(MeterRegistry registry) {
485486
return toValue.apply(search.apply(Search.in(registry)));
486487
}

implementations/micrometer-registry-kairos/src/main/java/io/micrometer/kairos/KairosConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public interface KairosConfig extends StepRegistryConfig {
4141
* Property prefix to prepend to configuration names.
4242
* @return property prefix
4343
*/
44+
@Override
4445
default String prefix() {
4546
return "kairos";
4647
}

implementations/micrometer-registry-opentsdb/src/main/java/io/micrometer/opentsdb/OpenTSDBConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public interface OpenTSDBConfig extends PushRegistryConfig {
3939
* Property prefix to prepend to configuration names.
4040
* @return property prefix
4141
*/
42+
@Override
4243
default String prefix() {
4344
return "opentsdb";
4445
}

implementations/micrometer-registry-otlp/src/test/java/io/micrometer/registry/otlp/OtlpCumulativeMeterRegistryTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ void gauge() {
4545
+ " time_unix_nano: 1000000\n" + " as_double: \\d+\\.0\n" + " }\n" + "}\n");
4646
}
4747

48+
@Override
4849
@Test
4950
void timeGauge() {
5051
TimeGauge timeGauge = TimeGauge.builder("gauge.time", this, TimeUnit.MICROSECONDS, o -> 24).register(registry);

implementations/micrometer-registry-otlp/src/test/java/io/micrometer/registry/otlp/OtlpDeltaMeterRegistryTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ void gauge() {
8686
.isEqualTo(otlpConfig().step().plus(Duration.ofMillis(1)).toNanos());
8787
}
8888

89+
@Override
8990
@Test
9091
void timeGauge() {
9192
TimeGauge timeGauge = TimeGauge.builder("gauge.time", this, TimeUnit.MICROSECONDS, o -> 24).register(registry);
@@ -356,6 +357,7 @@ void longTaskTimer() {
356357
UNIT_MILLISECONDS, 0, 0, 0);
357358
}
358359

360+
@Override
359361
@Test
360362
void testMetricsStartAndEndTime() {
361363
Counter counter = Counter.builder("test_publish_time").register(registry);

micrometer-core/src/main/java/io/micrometer/core/instrument/composite/AbstractCompositeMeter.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ T firstChild() {
6464
}
6565
}
6666

67+
@Override
6768
public final void add(MeterRegistry registry) {
6869
final T newMeter = registerNewMeter(registry);
6970
if (newMeter == null) {
@@ -90,6 +91,7 @@ public final void add(MeterRegistry registry) {
9091
* each meter belonging to the composite.
9192
* @param registry The registry to remove.
9293
*/
94+
@Override
9395
@Deprecated
9496
public final void remove(MeterRegistry registry) {
9597
for (;;) {

micrometer-core/src/main/java/io/micrometer/core/instrument/cumulative/CumulativeFunctionTimer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ public CumulativeFunctionTimer(Id id, T obj, ToLongFunction<T> countFunction, To
5959
/**
6060
* The total number of occurrences of the timed event.
6161
*/
62+
@Override
6263
public double count() {
6364
T obj2 = ref.get();
6465
return obj2 != null ? (lastCount = Math.max(countFunction.applyAsLong(obj2), 0)) : lastCount;
@@ -67,6 +68,7 @@ public double count() {
6768
/**
6869
* The total time of all occurrences of the timed event.
6970
*/
71+
@Override
7072
public double totalTime(TimeUnit unit) {
7173
T obj2 = ref.get();
7274
if (obj2 != null) {

0 commit comments

Comments
 (0)