#6313 handle out-of-order scope closure

Signed-off-by: Tomasz Grzejszczyk <[email protected]>

Author: tgrzej-avaloq

micrometer-observation/src/main/java/io/micrometer/observation/ObservationRegistry.java

@@ -73,6 +73,15 @@ static ObservationRegistry create() {
      */
     void setCurrentObservationScope(Observation.@Nullable Scope current);
 
+    /**
+     * Sets the observation scope as current only if the candidate is present in the
+     * registry.
+     * @param candidate observation scope
+     */
+    default void setCurrentObservationScopeIfExists(Observation.@Nullable Scope candidate) {
+        setCurrentObservationScope(candidate);
+    }
+
     /**
      * Configuration options for this registry.
      * @return observation configuration

micrometer-observation/src/main/java/io/micrometer/observation/SimpleObservation.java

@@ -313,7 +313,10 @@ else if (currentObservation != null && !currentObservation.isNoop()) {
             else {
                 log.trace("NoOp observation used with SimpleScope");
             }
-            this.registry.setCurrentObservationScope(previousObservationScope);
+            // DB connections might be closed out of order, so only set the previous scope
+            // as current if it has not been already closed (by checking if it still
+            // exists in the registry).
+            this.registry.setCurrentObservationScopeIfExists(previousObservationScope);
         }
 
         private @Nullable SimpleScope getLastScope(SimpleScope simpleScope) {

micrometer-observation/src/main/java/io/micrometer/observation/SimpleObservationRegistry.java

@@ -50,6 +50,23 @@ public void setCurrentObservationScope(Observation.@Nullable Scope current) {
         localObservationScope.set(current);
     }
 
+    @Override
+    public void setCurrentObservationScopeIfExists(Observation.@Nullable Scope candidate) {
+        if (candidate == null) {
+            setCurrentObservationScope(null);
+        }
+        else {
+            Observation.Scope scope = localObservationScope.get();
+            while (scope != null) {
+                if (scope.equals(candidate)) {
+                    setCurrentObservationScope(candidate);
+                    break;
+                }
+                scope = scope.getPreviousObservationScope();
+            }
+        }
+    }
+
     @Override
     public ObservationConfig observationConfig() {
         return this.observationConfig;