Skip to content

Commit 783d947

Browse files
shakuzenjonatan-ivanov
authored andcommitted
Backport JDK 24 build job to 1.15.x
We are testing 1.15.x with Java 24 too (see gh-6804) so changes in gh-6400 are needed on 1.15.x. Closes gh-6809 See gh-6804 See gh-6400
1 parent 34bf8c1 commit 783d947

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

.circleci/config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ jobs:
7171
executor: circle-jdk24-executor
7272
steps:
7373
- gradlew-build
74-
- run: ./gradlew jdk24Test
7574

7675
build:
7776
executor: circle-jdk-executor

micrometer-java21/build.gradle

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,6 @@ tasks.withType(JavaCompile).configureEach {
2222
options.release = 21
2323
}
2424

25-
tasks.register('jdk24Test', Test) {
26-
useJUnitPlatform {
27-
includeTags 'jdk24'
28-
}
29-
30-
javaLauncher = javaToolchains.launcherFor {
31-
languageVersion = JavaLanguageVersion.of(24)
32-
}
33-
}
34-
3525
tasks.register('reflectiveTests', Test) {
3626
useJUnitPlatform {
3727
includeTags 'reflective'
@@ -49,6 +39,6 @@ tasks.register('reflectiveTests', Test) {
4939
test {
5040
dependsOn reflectiveTests
5141
useJUnitPlatform {
52-
excludeTags 'reflective', 'jdk24'
42+
excludeTags 'reflective'
5343
}
5444
}

micrometer-java21/src/test/java/io/micrometer/java21/instrument/binder/jdk/VirtualThreadMetricsJdk24Tests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,17 @@
1919
import io.micrometer.core.instrument.simple.SimpleMeterRegistry;
2020
import org.junit.jupiter.api.AfterEach;
2121
import org.junit.jupiter.api.BeforeEach;
22-
import org.junit.jupiter.api.Tag;
2322
import org.junit.jupiter.api.Test;
23+
import org.junit.jupiter.api.condition.EnabledForJreRange;
24+
import org.junit.jupiter.api.condition.JRE;
2425

2526
import java.time.Duration;
2627
import java.util.concurrent.*;
2728
import java.util.concurrent.atomic.AtomicBoolean;
2829

2930
import static org.assertj.core.api.Assertions.assertThat;
3031

31-
@Tag("jdk24")
32+
@EnabledForJreRange(min = JRE.JAVA_24)
3233
class VirtualThreadMetricsJdk24Tests {
3334

3435
MeterRegistry registry = new SimpleMeterRegistry();

micrometer-java21/src/test/java/io/micrometer/java21/instrument/binder/jdk/VirtualThreadMetricsTests.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
import org.junit.jupiter.api.AfterEach;
2222
import org.junit.jupiter.api.BeforeEach;
2323
import org.junit.jupiter.api.Test;
24+
import org.junit.jupiter.api.condition.DisabledForJreRange;
25+
import org.junit.jupiter.api.condition.JRE;
2426

2527
import java.time.Duration;
2628
import java.util.ArrayList;
@@ -58,6 +60,8 @@ void tearDown() {
5860
}
5961

6062
@Test
63+
@DisabledForJreRange(min = JRE.JAVA_24,
64+
disabledReason = "It's not easy to test pinning with synchronized block pinning fixed in 24.")
6165
void pinnedEventsShouldBeRecorded() {
6266
try (ExecutorService executor = Executors.newVirtualThreadPerTaskExecutor()) {
6367
CountDownLatch latch = new CountDownLatch(1);

0 commit comments

Comments
 (0)