Skip to content

Commit ad3776d

Browse files
committed
Align OtlpConfigTest with CompressionMode enum values
Fix compression mode tests to use valid enum values (GZIP, NONE) instead of invalid values (ON, OFF). Add test coverage for OTEL_EXPORTER_OTLP_COMPRESSION fallback environment variable and precedence between generic and metrics-specific compression env vars. Signed-off-by: Tigran Kavanosyan <[email protected]>
1 parent 2750469 commit ad3776d

File tree

1 file changed

+18
-3
lines changed
  • implementations/micrometer-registry-otlp/src/test/java/io/micrometer/registry/otlp

1 file changed

+18
-3
lines changed

implementations/micrometer-registry-otlp/src/test/java/io/micrometer/registry/otlp/OtlpConfigTest.java

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,15 +320,30 @@ void compressionModeOn() {
320320

321321
@Test
322322
void compressionModeConfigTakesPrecedenceOverEnvVars() throws Exception {
323-
OtlpConfig config = k -> "ON";
324-
withEnvironmentVariable("OTEL_EXPORTER_OTLP_METRICS_COMPRESSION", "OFF")
323+
OtlpConfig config = k -> "GZIP";
324+
withEnvironmentVariable("OTEL_EXPORTER_OTLP_METRICS_COMPRESSION", "NONE")
325325
.execute(() -> assertThat(config.compressionMode()).isEqualTo(CompressionMode.GZIP));
326326
}
327327

328328
@Test
329329
void compressionModeUseEnvVarWhenConfigNotSet() throws Exception {
330330
OtlpConfig config = k -> null;
331-
withEnvironmentVariable("OTEL_EXPORTER_OTLP_METRICS_COMPRESSION", "ON")
331+
withEnvironmentVariable("OTEL_EXPORTER_OTLP_METRICS_COMPRESSION", "GZIP")
332+
.execute(() -> assertThat(config.compressionMode()).isEqualTo(CompressionMode.GZIP));
333+
}
334+
335+
@Test
336+
void compressionModeUseFallbackEnvVarWhenConfigNotSet() throws Exception {
337+
OtlpConfig config = k -> null;
338+
withEnvironmentVariable("OTEL_EXPORTER_OTLP_COMPRESSION", "GZIP")
339+
.execute(() -> assertThat(config.compressionMode()).isEqualTo(CompressionMode.GZIP));
340+
}
341+
342+
@Test
343+
void compressionModeMetricsEnvVarTakesPrecedenceOverGenericEnvVar() throws Exception {
344+
OtlpConfig config = k -> null;
345+
withEnvironmentVariables().set("OTEL_EXPORTER_OTLP_COMPRESSION", "NONE")
346+
.set("OTEL_EXPORTER_OTLP_METRICS_COMPRESSION", "GZIP")
332347
.execute(() -> assertThat(config.compressionMode()).isEqualTo(CompressionMode.GZIP));
333348
}
334349

0 commit comments

Comments
 (0)