Issue with CursoredPageable and @EmbeddedId

[cutz]

Expected Behavior

I'm running into an issue trying to use CursoredPageable on a repository whose entity is keyed by a complex primary key modeled as an @EmbeddedId . For example:

@Embeddable
public record AssetId(
        @MappedProperty("container_id")
        UUID containerId,
        @MappedProperty("asset_id")
        Integer assetId
) {
}

@MappedEntity("assets")
public record EphemeralAsset(
    @EmbeddedId
    AssetId id
){}

@JdbcRepository(dialect =  Dialect.POSTGRES)
public interface EphemeralAssetsRepository extends PageableRepository<EphemeralAsset, AssetId> {

    CursoredPage<EphemeralAsset> findByIdContainerId(UUID containerId, CursoredPageable pageable);
}

When invoking findByContainerId the generated query tries to add a sort clause for assets.id which is a column that does not exist. I think the EmbeddedId should be expanded to sort clauses for both assets.container_id and assets.asset_id. Is this a bug in Micronaut Data query generation or a misunderstanding on how EmbeddedId should be working?

Actual Behaviour

When invoking findByContainerId the generated query tries to add a sort clause for assets.id which is a column that does not exist.

Steps To Reproduce

No response

Environment Information

No response

Example Application

Example Application

Version

4.8.2

[cutz]

I've linked an example project above that demonstrates the issue. Running the tests you will find a failure with the following error.

Error executing SQL Query: SELECT asset_."id_container_id",asset_."id_asset_id",asset_."title" FROM "asset" asset_ WHERE (asset_."id_container_id" = ?) ORDER BY asset_.id ASC LIMIT 3 ERROR: column asset_.id does not exist
  Position: 136
io.micronaut.data.exceptions.DataAccessException: Error executing SQL Query: SELECT asset_."id_container_id",asset_."id_asset_id",asset_."title" FROM "asset" asset_ WHERE (asset_."id_container_id" = ?) ORDER BY asset_.id ASC LIMIT 3 ERROR: column asset_.id does not exist
  Position: 136
	at io.micronaut.data.jdbc.operations.DefaultJdbcRepositoryOperations.findAll(DefaultJdbcRepositoryOperations.java:389)
	at io.micronaut.data.jdbc.operations.DefaultJdbcRepositoryOperations.lambda$findAll$5(DefaultJdbcRepositoryOperations.java:540)
	at io.micronaut.data.jdbc.operations.DefaultJdbcRepositoryOperations.lambda$executeRead$23(DefaultJdbcRepositoryOperations.java:780)

The generated query attempts to sort on asset_.id which is not an actual column. I'm not sure where the issue is. I think it should be attempting to sort by the columns for the properties of the EmbeddedId, id_container_id, and id_asset_id.

[radovanradic]

@cutz This should be fixed in next micronaut-data release. I have verified it against your example app and it works, just need to change embedded id to have field names customized like this until this PR #3410 is merged (need to wait until 5.0 since it might cause some breaking changes and will need documentation etc.)

@Embeddable
public record AssetId (
        @MappedProperty("container_id")
        UUID containerId,
        @MappedProperty("asset_id")
        int assetId) { }

[cutz]

@radovanradic many thanks! I will verify when the next version of micronaut-data is released. I spent some time today trying to figure out how to run on a snapshot without much luck. Thanks for the quick help with this. Cheers.