Fix set invoker package for kotlin (#1625)

Author: altro3

openapi-generator/src/main/java/io/micronaut/openapi/generator/AbstractMicronautKotlinCodegen.java

@@ -79,6 +79,7 @@
 import static org.openapitools.codegen.CodegenConstants.API_PACKAGE;
 import static org.openapitools.codegen.CodegenConstants.INVOKER_PACKAGE;
 import static org.openapitools.codegen.CodegenConstants.MODEL_PACKAGE;
+import static org.openapitools.codegen.CodegenConstants.PACKAGE_NAME;
 import static org.openapitools.codegen.languages.KotlinClientCodegen.DATE_LIBRARY;
 import static org.openapitools.codegen.utils.StringUtils.camelize;
 import static org.openapitools.codegen.utils.StringUtils.underscore;
@@ -245,6 +246,7 @@ protected AbstractMicronautKotlinCodegen() {
 
         // Set client options that will be presented to user
         updateOption(INVOKER_PACKAGE, packageName);
+        updateOption(PACKAGE_NAME, packageName);
         updateOption(CodegenConstants.ARTIFACT_ID, artifactId);
         updateOption(CodegenConstants.API_PACKAGE, apiPackage);
         updateOption(CodegenConstants.MODEL_PACKAGE, modelPackage);
@@ -391,8 +393,10 @@ public void setApiPackage(String apiPackage) {
         updateOption(CodegenConstants.API_PACKAGE, apiPackage);
     }
 
-    public void setInvokerPackage(String packageName) {
+    public void setPackageName(String packageName) {
+        super.setPackageName(packageName);
         updateOption(INVOKER_PACKAGE, packageName);
+        updateOption(PACKAGE_NAME, packageName);
     }
 
     public void setPlural(boolean plural) {

openapi-generator/src/main/java/io/micronaut/openapi/generator/MicronautCodeGeneratorEntryPoint.java

@@ -196,7 +196,7 @@ private void configureOptions() {
         } else if (options.lang == GeneratorLanguage.KOTLIN && codeGenerator instanceof AbstractMicronautKotlinCodegen<?> kotlinCodeGen) {
 
             if (options.invokerPackage != null) {
-                kotlinCodeGen.setInvokerPackage(options.invokerPackage);
+                kotlinCodeGen.setPackageName(options.invokerPackage);
             }
             if (options.artifactId != null) {
                 kotlinCodeGen.setArtifactId(options.artifactId);

openapi-generator/src/main/resources/templates/java-micronaut/client/auth/AuthorizationBinder.mustache

@@ -40,9 +40,9 @@ public class AuthorizationBinder implements AnnotatedClientRequestBinder<Authori
                 .getAnnotationValuesByType(Authorization.class);
 
         if (CollectionUtils.isNotEmpty(annotations)) {
-            List<String> authorizationNames = new ArrayList<>();
+            var authorizationNames = new ArrayList<String>();
             for (AnnotationValue<Authorization> annotation : annotations) {
-                annotation.get("name", String.class)
+                annotation.stringValue("name")
                         .filter(StringUtils::isNotEmpty)
                         .ifPresent(v -> authorizationNames.add(configurationName(v)));
             }

openapi-generator/src/main/resources/templates/kotlin-micronaut/client/auth/AuthorizationBinder.mustache

@@ -34,9 +34,9 @@ open class AuthorizationBinder : AnnotatedClientRequestBinder<Authorization> {
         if (annotations.isNotEmpty()) {
             val authorizationNames = ArrayList<String>()
             for (ann in annotations) {
-                ann.get("name", String::class.java)
-                        .filter{ s -> !s.isNullOrEmpty()}
-                        .ifPresent {v -> authorizationNames.add(configurationName(v))}
+                ann.stringValue("name")
+                        .filter{ s -> !s.isNullOrEmpty() }
+                        .ifPresent { v -> authorizationNames.add(configurationName(v)) }
             }
             request.setAttribute(AUTHORIZATION_NAMES, authorizationNames)
         }

openapi-generator/src/main/resources/templates/kotlin-micronaut/client/auth/AuthorizationFilter.mustache

@@ -12,7 +12,6 @@ import io.micronaut.http.filter.ClientFilterChain
 import io.micronaut.http.filter.HttpClientFilter
 import io.micronaut.inject.qualifiers.Qualifiers
 import io.micronaut.security.oauth2.client.clientcredentials.ClientCredentialsClient
-import io.micronaut.security.oauth2.client.clientcredentials.ClientCredentialsConfiguration
 import io.micronaut.security.oauth2.client.clientcredentials.propagation.ClientCredentialsHttpClientFilter
 import io.micronaut.security.oauth2.client.clientcredentials.propagation.ClientCredentialsTokenPropagator
 import io.micronaut.security.oauth2.configuration.OauthClientConfiguration
@@ -32,7 +31,7 @@ import {{javaxPackage}}.annotation.Generated
 {{/generatedAnnotation}}
 @Filter({{#configureAuthFilterPattern}}"{{authorizationFilterPattern}}"{{/configureAuthFilterPattern}}{{^configureAuthFilterPattern}}Filter.MATCH_ALL_PATTERN{{/configureAuthFilterPattern}})
 open class AuthorizationFilter(
-    defaultTokenPropagator: ClientCredentialsTokenPropagator,
+    var defaultTokenPropagator: ClientCredentialsTokenPropagator?,
     clientConfigurations: Stream<OauthClientConfiguration>,
     configurableAuthorizations: Stream<ConfigurableAuthorization>,
     private val beanContext: BeanContext,
@@ -46,12 +45,12 @@ open class AuthorizationFilter(
 
     init {
         clientConfigurationByName = clientConfigurations
-                .filter { obj: OauthClientConfiguration -> obj.isEnabled }
-                .collect(Collectors.toMap({ obj: OauthClientConfiguration -> obj.name }, { v: OauthClientConfiguration? -> v }))
+                .filter { it.isEnabled }
+                .collect(Collectors.toMap({ it.name }, { it }))
         tokenPropagatorByName = HashMap()
         clientCredentialsClientByName = HashMap()
         authorizationsByName = configurableAuthorizations
-                .collect(Collectors.toMap({ obj: ConfigurableAuthorization -> obj.getName() }, { v: ConfigurableAuthorization? -> v }))
+                .collect(Collectors.toMap({ it.name }, { it }))
     }
 
     override fun doFilter(request: @NonNull MutableHttpRequest<*>, chain: @NonNull ClientFilterChain): Publisher<out HttpResponse<*>?> {
@@ -124,7 +123,7 @@ open class AuthorizationFilter(
 
     protected fun getScope(oauthClient: @NonNull OauthClientConfiguration): @Nullable String? {
         return oauthClient.clientCredentials
-                .flatMap { obj: ClientCredentialsConfiguration -> obj.scope }
+                .flatMap { it.scope }
                 .orElse(null)
     }
 

openapi-generator/src/main/resources/templates/kotlin-micronaut/client/auth/configuration/ApiKeyAuthConfiguration.mustache

@@ -16,11 +16,11 @@ import {{javaxPackage}}.annotation.Generated
 {{/generatedAnnotation}}
 @EachProperty("security.api-key-auth")
 data class ApiKeyAuthConfiguration(
-    @Parameter val name: String,
+    @Parameter override val name: String,
     @NonNull var location: AuthKeyLocation,
     @NonNull var paramName: String,
     @NonNull var apiKey: String
-): ConfigurableAuthorization {
+) : ConfigurableAuthorization {
 
     override fun applyAuthorization(@NonNull request: MutableHttpRequest<*>) {
         when (location) {
@@ -36,8 +36,6 @@ data class ApiKeyAuthConfiguration(
         }
     }
 
-    override fun getName() = name
-
     enum class AuthKeyLocation {
         HEADER,
         QUERY,

openapi-generator/src/main/resources/templates/kotlin-micronaut/client/auth/configuration/ConfigurableAuthorization.mustache

@@ -12,7 +12,7 @@ import {{javaxPackage}}.annotation.Generated
 {{/generatedAnnotation}}
 interface ConfigurableAuthorization {
 
-    fun getName(): String
+    val name: String
 
     fun applyAuthorization(@NonNull request: MutableHttpRequest<*>)
 }

openapi-generator/src/main/resources/templates/kotlin-micronaut/client/auth/configuration/HttpBasicAuthConfiguration.mustache

@@ -15,14 +15,12 @@ import {{javaxPackage}}.annotation.Generated
 {{/generatedAnnotation}}
 @EachProperty("security.basic-auth")
 data class HttpBasicAuthConfiguration(
-    @Parameter val name: String,
+    @Parameter override val name: String,
     @NonNull var username: String,
     @NonNull var password: String
 ) : ConfigurableAuthorization {
 
     override fun applyAuthorization(@NonNull request: MutableHttpRequest<*>) {
         request.basicAuth(username, password)
     }
-
-    override fun getName() = name
 }

test-suite-kotlin-kapt-server-generator/src/main/kotlin/io/micronaut/openapi/test/dated/DatedResponseBodyWriter.kt

@@ -34,7 +34,7 @@ internal class DatedResponseBodyWriter<T> private constructor(
     override fun createSpecific(
             type: Argument<DatedResponse<T>>
     ): MessageBodyWriter<DatedResponse<T>> {
-        val bt: Argument<T> = type.typeParameters[0] as Argument<T>
+        val bt = type.typeParameters[0] as Argument<T>
         val writer = registry.findWriter(bt, listOf(MediaType.APPLICATION_JSON_TYPE))
                 .orElseThrow { ConfigurationException("No JSON message writer present") }
         return DatedResponseBodyWriter(registry, writer, bt)

test-suite-kotlin-kapt-server-generator/src/main/kotlin/io/micronaut/openapi/test/filter/MyFilter.kt

@@ -12,10 +12,10 @@ import java.util.regex.Pattern
  * @param conditions The filtering conditions
  */
 data class MyFilter(
-        val conditions: List<Condition>
+    val conditions: List<Condition>
 ) {
 
-    override fun toString(): String = conditions.joinToString( ",", transform = { it.toString() })
+    override fun toString() = conditions.joinToString(",", transform = { it.toString() })
 
     /**
      * A filtering condition.
@@ -30,9 +30,7 @@ data class MyFilter(
         val value: Any,
     ) {
 
-        override fun toString(): String {
-            return propertyName + comparator + value
-        }
+        override fun toString() = propertyName + comparator + value
 
         companion object {
             /**
@@ -48,9 +46,9 @@ data class MyFilter(
                     throw ParseException("The filter condition must match '$CONDITION_REGEX' but is '$string'")
                 }
                 return Condition(
-                        matcher.group(1),
-                        ConditionComparator.parse(matcher.group(2)),
-                        matcher.group(3)
+                    matcher.group(1),
+                    ConditionComparator.parse(matcher.group(2)),
+                    matcher.group(3)
                 )
             }
         }
@@ -98,6 +96,7 @@ data class MyFilter(
 
     companion object {
         private const val CONDITION_REGEX = "^(.+)([<>=])(.+)$"
+
         /**
          * An implementation with no filtering.
          */
@@ -116,8 +115,7 @@ data class MyFilter(
                 return EMPTY
             }
             val conditions = value.split(",")
-                    .map { Condition.parse(it) }
-                    .toList()
+                .map { Condition.parse(it) }
             return MyFilter(conditions)
         }
     }