fix a crash bug where BSS size calculation was attempted on the value of a data item (bytes) instead of the size of that data item (int)

The size of the bss section was increased with the value of the defined symbol
rather than the size of that value (number of bytes). This change fixes that.

Author: wnienhaus

esp32_ulp/assemble.py

@@ -150,8 +150,8 @@ def append_section(self, value, expected_section=None):
         if expected_section is not None and s is not expected_section:
             raise TypeError('only allowed in %s section' % expected_section)
         if s is BSS:
-            # just increase BSS size by value
-            self.offsets[s] += value
+            # just increase BSS size by length of value
+            self.offsets[s] += len(value)
         else:
             self.sections[s].append(value)
             self.offsets[s] += len(value)

tests/assemble.py

@@ -14,6 +14,13 @@
 .data
 """
 
+src_bss = """\
+  .bss
+
+label:
+  .long 0
+"""
+
 
 def test_parse_line():
     a = Assembler()
@@ -52,6 +59,18 @@ def test_assemble():
     assert a.offsets[BSS] == 0
 
 
+def test_assemble_bss():
+    a = Assembler()
+    try:
+        a.assemble(src_bss)
+    except TypeError:
+        raised = True
+    else:
+        raised = False
+    assert not raised
+    assert a.offsets[BSS] == 4  # 1 word * 4B
+
+
 def test_symbols():
     st = SymbolTable({}, {})
     for entry in [
@@ -108,4 +127,5 @@ def test_symbols():
 test_parse_line()
 test_parse()
 test_assemble()
+test_assemble_bss()
 test_symbols()