Skip to content

Commit 7cde971

Browse files
authored
Refactor timestamp handling in FileTranscriptStore and update related tests for consistency (#166)
1 parent 92be5d1 commit 7cde971

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/storage/transcript_file_store.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ async def log_activity(self, activity: Activity) -> None:
7171
def _write() -> None:
7272
# Normalize to a dict to ensure json serializable content.
7373
if not activity.timestamp:
74-
activity.timestamp = _utc_iso_now()
74+
activity.timestamp = datetime.now(timezone.utc)
7575

7676
with open(file_path, "a", encoding="utf-8", newline="\n") as f:
7777
f.write(activity.model_dump_json(exclude_none=True, exclude_unset=True))
@@ -261,7 +261,3 @@ def _to_plain_dict(activity: Activity) -> Dict[str, Any]:
261261
"conversation": {"id": conversation_id},
262262
"text": getattr(activity, "text", None),
263263
}
264-
265-
266-
def _utc_iso_now() -> str:
267-
return datetime.now(timezone.utc).isoformat()

tests/hosting_core/storage/test_file_transcript_storage.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ async def test_get_transcript_activities_with_paging(temp_logger: FileTranscript
134134
async def test_get_transcript_activities_with_start_date_filter(
135135
temp_logger: FileTranscriptStore,
136136
):
137-
old_ts = (datetime.now(timezone.utc) - timedelta(days=2)).isoformat()
138-
new_ts = datetime.now(timezone.utc).isoformat()
137+
old_ts = datetime.now(timezone.utc) - timedelta(days=2)
138+
new_ts = datetime.now(timezone.utc)
139139

140140
activity1 = make_activity(conv="filtered", text="old")
141141
activity2 = make_activity(conv="filtered", text="new")

0 commit comments

Comments
 (0)