Fix IntLiteralCast ErrorProne violations by using float literals instead of casting

Co-authored-by: trask <[email protected]>

Author: Copilot

agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java

@@ -30,14 +30,14 @@ private static AlertingSubsystem getAlertMonitor(
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build(),
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build(),
@@ -89,14 +89,14 @@ void manualAlertWorks() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build(),
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build(),
@@ -130,14 +130,14 @@ void manualAlertDoesNotTriggerAfterExpired() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build(),
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build(),

agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java

@@ -43,7 +43,7 @@ void saneDataIsParsed() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build());
@@ -53,7 +53,7 @@ void saneDataIsParsed() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build());

buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts

@@ -74,7 +74,6 @@ tasks {
 
         // New checks in ErrorProne 2.38.0 that we want to disable
         disable("AddNullMarkedToPackageInfo")
-        disable("IntLiteralCast")
 
         // Other new checks that cause warnings in our codebase
         disable("EnumOrdinal")