Obsoloteing sanitize methods in this classes and updating tests accordingly

Author: dhaval24

core/src/main/java/com/microsoft/applicationinsights/telemetry/BaseTelemetry.java

@@ -32,6 +32,7 @@
 import com.microsoft.applicationinsights.internal.schemav2.Envelope;
 import com.microsoft.applicationinsights.internal.util.LocalStringsUtils;
 import com.microsoft.applicationinsights.internal.util.Sanitizer;
+import org.apache.http.annotation.Obsolete;
 import sun.reflect.generics.reflectiveObjects.NotImplementedException;
 
 /**
@@ -125,6 +126,7 @@ public Map<String, String> getProperties() {
      * Makes sure the data to send is sanitized from bad chars, proper length etc.
      */
     @Override
+    @Obsolete
     public void sanitize() {
         Sanitizer.sanitizeProperties(this.getProperties());
         additionalSanitize();
@@ -162,6 +164,7 @@ public void reset() {
     /**
      * Concrete classes should implement this method
      */
+    @Obsolete
     protected abstract void additionalSanitize();
 
     /**

core/src/main/java/com/microsoft/applicationinsights/telemetry/EventTelemetry.java

@@ -28,6 +28,7 @@
 
 import com.google.common.base.Strings;
 import com.microsoft.applicationinsights.internal.util.Sanitizer;
+import org.apache.http.annotation.Obsolete;
 
 /**
  * Telemetry type used to track custom events in Azure Application Insights. 
@@ -102,6 +103,7 @@ public void setName(String name) {
      * Sanitize name and metrics.
      */
     @Override
+    @Obsolete
     protected void additionalSanitize() {
         data.setName(Sanitizer.sanitizeName(data.getName()));
         Sanitizer.sanitizeMeasurements(this.getMetrics());

core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java

@@ -140,6 +140,7 @@ public void setSamplingPercentage(Double samplingPercentage) {
         this.samplingPercentage = samplingPercentage;
     }
 
+    @Obsolete
     @Override
     protected void additionalSanitize() {
         Sanitizer.sanitizeMeasurements(this.getMetrics());

core/src/main/java/com/microsoft/applicationinsights/telemetry/MetricTelemetry.java

@@ -28,6 +28,7 @@
 
 import com.google.common.base.Strings;
 import com.microsoft.applicationinsights.internal.util.Sanitizer;
+import org.apache.http.annotation.Obsolete;
 
 /**
  * Telemetry type used to track metrics sent to Azure Application Insights.
@@ -176,6 +177,7 @@ public void setStandardDeviation(Double value) {
         metric.setStdDev(value); updateKind();
     }
 
+    @Obsolete
     @Override
     protected void additionalSanitize() {
         metric.setName(Sanitizer.sanitizeName(metric.getName()));

core/src/main/java/com/microsoft/applicationinsights/telemetry/PageViewTelemetry.java

@@ -26,6 +26,7 @@
 
 import com.microsoft.applicationinsights.internal.schemav2.PageViewData;
 import com.microsoft.applicationinsights.internal.util.Sanitizer;
+import org.apache.http.annotation.Obsolete;
 
 /**
  * Telemetry type used to track page views.
@@ -137,6 +138,7 @@ public void setSamplingPercentage(Double samplingPercentage) {
     }
 
     @Override
+    @Obsolete
     protected void additionalSanitize() {
         data.setName(Sanitizer.sanitizeName(data.getName()));
         Sanitizer.sanitizeMeasurements(this.getMetrics());

core/src/main/java/com/microsoft/applicationinsights/telemetry/PerformanceCounterTelemetry.java

@@ -25,6 +25,7 @@
 
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
+import org.apache.http.annotation.Obsolete;
 
 /**
  * The class that represents information about performance counters.
@@ -134,6 +135,7 @@ public double getValue() {
     }
 
     @Override
+    @Obsolete
     protected void additionalSanitize() {
 
     }

core/src/main/java/com/microsoft/applicationinsights/telemetry/RemoteDependencyTelemetry.java

@@ -310,6 +310,7 @@ public void setSamplingPercentage(Double samplingPercentage) {
     }
 
     @Override
+    @Obsolete
     protected void additionalSanitize() {
         data.setName(Sanitizer.sanitizeName(data.getName()));
     }

core/src/main/java/com/microsoft/applicationinsights/telemetry/RequestTelemetry.java

@@ -272,6 +272,7 @@ public void setSamplingPercentage(Double samplingPercentage) {
     }
 
     @Override
+    @Obsolete
     protected void additionalSanitize() {
         data.setName(Sanitizer.sanitizeName(data.getName()));
         data.setId(Sanitizer.sanitizeName(data.getId()));

core/src/main/java/com/microsoft/applicationinsights/telemetry/SessionStateTelemetry.java

@@ -24,6 +24,7 @@
 import java.util.concurrent.ConcurrentHashMap;
 
 import com.microsoft.applicationinsights.internal.schemav2.SessionStateData;
+import org.apache.http.annotation.Obsolete;
 
 /**
  * Telemetry type used to track user sessions in Azure Application Insights.
@@ -75,6 +76,7 @@ public void setSessionState(SessionState sessionState) {
         data.setState(sessionState);;
     }
 
+    @Obsolete
     @Override
     protected void additionalSanitize() {
     }

core/src/main/java/com/microsoft/applicationinsights/telemetry/Telemetry.java

@@ -21,6 +21,8 @@
 
 package com.microsoft.applicationinsights.telemetry;
 
+import org.apache.http.annotation.Obsolete;
+
 import java.io.IOException;
 import java.util.Date;
 import java.util.Map;
@@ -76,6 +78,7 @@ public interface Telemetry extends JsonSerializable
     /**
      * Sanitizes the properties of the telemetry item based on DP constraints.
      */
+    @Obsolete
     void sanitize();
 
     /**