Skip to content

Commit 11821d4

Browse files
committed
Fix role instance configuration not applied
1 parent 9bd435b commit 11821d4

File tree

2 files changed

+4
-24
lines changed

2 files changed

+4
-24
lines changed

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/BeforeAgentInstaller.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
import com.microsoft.applicationinsights.agent.internal.instrumentation.sdk.PerformanceCounterModuleClassFileTransformer;
4747
import com.microsoft.applicationinsights.agent.internal.instrumentation.sdk.QuickPulseClassFileTransformer;
4848
import com.microsoft.applicationinsights.agent.internal.instrumentation.sdk.TelemetryClientClassFileTransformer;
49-
import com.microsoft.applicationinsights.extensibility.initializer.CloudInfoContextInitializer;
49+
import com.microsoft.applicationinsights.common.CommonUtils;
5050
import com.microsoft.applicationinsights.extensibility.initializer.DeviceInfoContextInitializer;
5151
import com.microsoft.applicationinsights.extensibility.initializer.SdkVersionContextInitializer;
5252
import com.microsoft.applicationinsights.internal.channel.common.ApacheSender43;
@@ -151,7 +151,6 @@ private static void start(Instrumentation instrumentation, File agentJarFile) th
151151
TelemetryConfigurationFactory.INSTANCE.initialize(configuration, buildXmlConfiguration(config));
152152
configuration.getContextInitializers().add(new SdkVersionContextInitializer());
153153
configuration.getContextInitializers().add(new DeviceInfoContextInitializer());
154-
configuration.getContextInitializers().add(new CloudInfoContextInitializer());
155154

156155
FixedRateSampling fixedRateSampling = config.preview.sampling.fixedRate;
157156
if (fixedRateSampling != null && fixedRateSampling.percentage != null) {
@@ -273,6 +272,9 @@ private static ApplicationInsightsXmlConfiguration buildXmlConfiguration(Instrum
273272
}
274273
if (!Strings.isNullOrEmpty(config.preview.roleInstance)) {
275274
xmlConfiguration.setRoleInstance(config.preview.roleInstance);
275+
} else {
276+
String hostname = CommonUtils.getHostName();
277+
xmlConfiguration.setRoleInstance(hostname == null ? "unknown" : hostname);
276278
}
277279

278280
// configure heartbeat module

core/src/main/java/com/microsoft/applicationinsights/extensibility/initializer/CloudInfoContextInitializer.java

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)