Update errorprone

trask · trask · commit 126ed268af94 · 2021-08-30T15:14:06.000-07:00
diff --git a/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/MachineNameFinder.java b/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/MachineNameFinder.java
@@ -21,10 +21,13 @@
 
 package com.microsoft.applicationinsights.agent.bootstrap.diagnostics;
 
+import org.checkerframework.checker.nullness.qual.Nullable;
+
 public class MachineNameFinder extends CachedDiagnosticsValueFinder {
   public static final String PROPERTY_NAME = "MachineName";
 
   @Override
+  @Nullable
   protected String populateValue() {
     String computerName = System.getenv("COMPUTERNAME");
     if (computerName != null) {
diff --git a/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/PidFinder.java b/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/PidFinder.java
@@ -24,6 +24,7 @@
 import java.lang.management.ManagementFactory;
 import java.lang.management.RuntimeMXBean;
 import java.lang.reflect.Method;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 public class PidFinder extends CachedDiagnosticsValueFinder {
   public static final String PROPERTY_NAME = "PID";
@@ -38,6 +39,7 @@ protected String populateValue() {
     return getPidUsingRuntimeBean();
   }
 
+  @Nullable
   private static String getPidUsingRuntimeBean() {
     // will only work with sun based jvm
     RuntimeMXBean rb = ManagementFactory.getRuntimeMXBean();
@@ -59,6 +61,7 @@ private static String getPidUsingRuntimeBean() {
     }
   }
 
+  @Nullable
   private static String getPidUsingProcessHandle() {
     try {
       // if java.specification.version < 9, the next line will fail.
diff --git a/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/SiteNameFinder.java b/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/SiteNameFinder.java
@@ -21,6 +21,8 @@
 
 package com.microsoft.applicationinsights.agent.bootstrap.diagnostics;
 
+import org.checkerframework.checker.nullness.qual.Nullable;
+
 public class SiteNameFinder extends CachedDiagnosticsValueFinder {
   // visible for testing
   static final String WEBSITE_SITE_NAME_ENV_VAR = "WEBSITE_SITE_NAME";
@@ -33,6 +35,7 @@ public String getName() {
   }
 
   @Override
+  @Nullable
   protected String populateValue() {
     String value = System.getenv(SiteNameFinder.WEBSITE_SITE_NAME_ENV_VAR);
     return value == null || value.isEmpty() ? null : value;
diff --git a/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/status/StatusFile.java b/agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/status/StatusFile.java
@@ -43,6 +43,7 @@
 import java.util.concurrent.TimeUnit;
 import okio.BufferedSink;
 import okio.Okio;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -313,6 +314,7 @@ private static String getUniqueId(Object pid) {
     }
   }
 
+  @Nullable
   private static String capitalize(String input) {
     if (input == null) {
       return null;
diff --git a/agent/agent-profiler/agent-alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/config/AlertingConfiguration.java b/agent/agent-profiler/agent-alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/config/AlertingConfiguration.java
@@ -22,6 +22,7 @@
 package com.microsoft.applicationinsights.alerting.config;
 
 import java.util.Objects;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 /** Contains the overall configuration of the entire alerting subsystem. */
 public class AlertingConfiguration {
@@ -66,7 +67,7 @@ public CollectionPlanConfiguration getCollectionPlanConfiguration() {
   }
 
   @Override
-  public boolean equals(Object obj) {
+  public boolean equals(@Nullable Object obj) {
     if (obj == this) {
       return true;
     }
@@ -124,7 +125,7 @@ public long getCooldown() {
     }
 
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(@Nullable Object obj) {
       if (obj == this) {
         return true;
       }
diff --git a/agent/agent-profiler/agent-alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/config/CollectionPlanConfiguration.java b/agent/agent-profiler/agent-alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/config/CollectionPlanConfiguration.java
@@ -23,6 +23,7 @@
 
 import java.time.ZonedDateTime;
 import java.util.Objects;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 public class CollectionPlanConfiguration {
 
@@ -81,7 +82,7 @@ public String getSettingsMoniker() {
   }
 
   @Override
-  public boolean equals(Object obj) {
+  public boolean equals(@Nullable Object obj) {
     if (obj == this) {
       return true;
     }
diff --git a/agent/agent-profiler/agent-alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/config/DefaultConfiguration.java b/agent/agent-profiler/agent-alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/config/DefaultConfiguration.java
@@ -22,6 +22,7 @@
 package com.microsoft.applicationinsights.alerting.config;
 
 import java.util.Objects;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 public class DefaultConfiguration {
 
@@ -37,7 +38,7 @@ public DefaultConfiguration(
   }
 
   @Override
-  public boolean equals(Object obj) {
+  public boolean equals(@Nullable Object obj) {
     if (obj == this) {
       return true;
     }
diff --git a/agent/agent-profiler/agent-alerting/src/main/java/com/microsoft/applicationinsights/alerting/analysis/TelemetryDataPoint.java b/agent/agent-profiler/agent-alerting/src/main/java/com/microsoft/applicationinsights/alerting/analysis/TelemetryDataPoint.java
@@ -24,6 +24,7 @@
 import com.microsoft.applicationinsights.alerting.config.AlertMetricType;
 import java.time.ZonedDateTime;
 import java.util.Objects;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 /** Individual sample of telemetry data. */
 public class TelemetryDataPoint implements Comparable<TelemetryDataPoint> {
@@ -62,7 +63,7 @@ public AlertMetricType getType() {
   }
 
   @Override
-  public boolean equals(Object obj) {
+  public boolean equals(@Nullable Object obj) {
     if (obj == this) {
       return true;
     }
diff --git a/agent/agent-profiler/agent-service-profiler/src/main/java/com/microsoft/applicationinsights/serviceprofilerapi/client/uploader/OsPlatformProvider.java b/agent/agent-profiler/agent-service-profiler/src/main/java/com/microsoft/applicationinsights/serviceprofilerapi/client/uploader/OsPlatformProvider.java
@@ -22,12 +22,14 @@
 package com.microsoft.applicationinsights.serviceprofilerapi.client.uploader;
 
 import com.microsoft.applicationinsights.serviceprofilerapi.client.contract.OsPlatforms;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
 public final class OsPlatformProvider {
   private static final Logger LOGGER = LoggerFactory.getLogger(OsPlatformProvider.class.getName());
 
+  @Nullable
   public static String getOsPlatformDescription() {
     if (isWindows()) {
       return OsPlatforms.WINDOWS;
diff --git a/agent/agent-profiler/agent-service-profiler/src/main/java/com/microsoft/applicationinsights/serviceprofilerapi/profiler/JfrProfiler.java b/agent/agent-profiler/agent-service-profiler/src/main/java/com/microsoft/applicationinsights/serviceprofilerapi/profiler/JfrProfiler.java
@@ -48,6 +48,7 @@
 import java.util.function.Consumer;
 import javax.management.InstanceNotFoundException;
 import javax.management.MBeanServerConnection;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -184,6 +185,7 @@ protected void profileAndUpload(AlertBreach alertBreach, Duration duration) {
         alertBreach.getType(), duration, uploadNewRecording(alertBreach, recordingStart));
   }
 
+  @Nullable
   private Recording startRecording(AlertMetricType alertType) {
     synchronized (activeRecordingLock) {
       if (activeRecording != null) {
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/common/HostName.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/common/HostName.java
@@ -23,6 +23,7 @@
 
 import java.net.InetAddress;
 import java.net.UnknownHostException;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -37,6 +38,7 @@ public class HostName {
    *
    * @return the local hostname, or null
    */
+  @Nullable
   public static String get() {
     try {
       InetAddress addr = InetAddress.getLocalHost();
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/common/Strings.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/common/Strings.java
@@ -31,6 +31,7 @@ public static boolean isNullOrEmpty(@Nullable String string) {
     return string == null || string.isEmpty();
   }
 
+  @Nullable
   public static String trimAndEmptyToNull(String str) {
     if (str == null) {
       return null;
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/configuration/RpConfigurationBuilder.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/configuration/RpConfigurationBuilder.java
@@ -29,12 +29,14 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.attribute.BasicFileAttributes;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 public class RpConfigurationBuilder {
 
   private static final String APPLICATIONINSIGHTS_RP_CONFIGURATION_FILE =
       "APPLICATIONINSIGHTS_RP_CONFIGURATION_FILE";
 
+  @Nullable
   public static RpConfiguration create(Path agentJarPath) throws IOException {
     Path configPath;
     String configPathString =
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/exporter/Exporter.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/exporter/Exporter.java
@@ -763,6 +763,7 @@ private void exportRequest(SpanData span) {
     exportEvents(span, operationName, samplingPercentage);
   }
 
+  @Nullable
   private static String getSource(Attributes attributes) {
     // this is only used by the 2.x web interop bridge
     // for ThreadContext.getRequestTelemetryContext().getRequestTelemetry().setSource()
@@ -978,6 +979,7 @@ private static void setExtraAttributes(
         });
   }
 
+  @Nullable
   private static String getStringValue(AttributeKey<?> attributeKey, Object value) {
     switch (attributeKey.getType()) {
       case STRING:
@@ -1006,6 +1008,7 @@ private static <T> String join(List<T> values) {
     return sb.toString();
   }
 
+  @Nullable
   private static SeverityLevel toSeverityLevel(String level) {
     if (level == null) {
       return null;
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/RedirectPolicy.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/RedirectPolicy.java
@@ -29,6 +29,7 @@
 import io.opentelemetry.instrumentation.api.caching.Cache;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import reactor.core.publisher.Mono;
@@ -100,6 +101,7 @@ private void cacheRedirectUrl(String redirectUrl, String instrumentationKey, URL
     }
   }
 
+  @Nullable
   private String getCachedRedirectUrl(String instrumentationKey, URL originalUrl) {
     if (!followInstrumentationKeyForRedirect) {
       return redirectMappings.get(originalUrl);
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/SslUtil.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/httpclient/SslUtil.java
@@ -24,6 +24,7 @@
 import com.microsoft.applicationinsights.agent.internal.common.FriendlyException;
 import com.microsoft.applicationinsights.agent.internal.configuration.DefaultEndpoints;
 import java.io.File;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 public class SslUtil {
 
@@ -40,6 +41,7 @@ private static String getJavaCacertsPath() {
     return new File(javaHome, "lib/security/cacerts").getPath();
   }
 
+  @Nullable
   private static String getCustomJavaKeystorePath() {
     String cacertsPath = System.getProperty("javax.net.ssl.trustStore");
     if (cacertsPath != null) {
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/DuplicateAgentClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/DuplicateAgentClassFileTransformer.java
@@ -98,6 +98,7 @@ private DuplicateAgentClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/MainEntryPoint.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/MainEntryPoint.java
@@ -39,6 +39,7 @@
 import java.lang.instrument.Instrumentation;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Path;
+import org.checkerframework.checker.nullness.qual.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.slf4j.MDC;
@@ -129,6 +130,7 @@ public static void start(Instrumentation instrumentation, File javaagentFile) {
   }
 
   // visible for testing
+  @Nullable
   static FriendlyException getFriendlyException(Throwable t) {
     if (t instanceof FriendlyException) {
       return (FriendlyException) t;
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/ApplicationInsightsAppenderClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/ApplicationInsightsAppenderClassFileTransformer.java
@@ -81,6 +81,7 @@ private ApplicationInsightsAppenderClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/BytecodeUtilImpl.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/BytecodeUtilImpl.java
@@ -415,6 +415,7 @@ public void trackException(
     track(telemetry);
   }
 
+  @Nullable
   private static SeverityLevel getSeverityLevel(int value) {
     // these mappings from the 2.x SDK
     switch (value) {
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/HeartBeatModuleClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/HeartBeatModuleClassFileTransformer.java
@@ -77,6 +77,7 @@ private HeartBeatModuleClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/PerformanceCounterModuleClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/PerformanceCounterModuleClassFileTransformer.java
@@ -77,6 +77,7 @@ private PerformanceCounterModuleClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/QuickPulseClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/QuickPulseClassFileTransformer.java
@@ -77,6 +77,7 @@ private QuickPulseClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/RequestNameHandlerClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/RequestNameHandlerClassFileTransformer.java
@@ -76,6 +76,7 @@ private RequestNameHandlerClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/TelemetryClientClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/TelemetryClientClassFileTransformer.java
@@ -132,6 +132,7 @@ public FieldVisitor visitField(
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/WebRequestTrackingFilterClassFileTransformer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/legacysdk/WebRequestTrackingFilterClassFileTransformer.java
@@ -77,6 +77,7 @@ private WebRequestTrackingFilterClassVisitor(ClassWriter cw) {
     }
 
     @Override
+    @Nullable
     public MethodVisitor visitMethod(
         int access,
         String name,
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileLoader.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileLoader.java
@@ -28,6 +28,7 @@
 import java.nio.file.Files;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.io.FilenameUtils;
+import org.checkerframework.checker.nullness.qual.Nullable;
 
 /** This class manages loading a list of {@link ByteBuffer} from the disk. */
 public class LocalFileLoader {
@@ -46,6 +47,7 @@ public LocalFileLoader(LocalFileCache localFileCache, File telemetryFolder) {
   }
 
   // Load ByteBuffer from persisted files on disk in FIFO order.
+  @Nullable
   ByteBuffer loadTelemetriesFromDisk() {
     // TODO (heya) how does this load files from disk at startup that were left over from prior
     //  process?
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java
@@ -57,6 +57,7 @@ public static AttributeProcessor create(ProcessorConfig config) {
 
   // this won't be needed once we update to 0.13.0
   // see https://github.com/open-telemetry/opentelemetry-java/pull/2284
+  @Nullable
   public static String getAttribute(Attributes attributes, AttributeKey<String> key) {
     Object existingValueObj = attributes.get(key);
     // checking the return type won't be needed once we update to 0.13.0
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataCollector.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/quickpulse/QuickPulseDataCollector.java
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/quickpulse/util/CustomCharacterEscapes.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/quickpulse/util/CustomCharacterEscapes.java
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplingOverrides.java
diff --git a/buildSrc/build.gradle.kts b/buildSrc/build.gradle.kts
diff --git a/dependencyManagement/build.gradle.kts b/dependencyManagement/build.gradle.kts
diff --git a/test/fakeIngestion/servlet/src/main/java/com/microsoft/applicationinsights/test/fakeingestion/MockedAppInsightsIngestionServlet.java b/test/fakeIngestion/servlet/src/main/java/com/microsoft/applicationinsights/test/fakeingestion/MockedAppInsightsIngestionServlet.java
diff --git a/test/smoke/framework/testCore/src/main/java/com/microsoft/applicationinsights/smoketest/docker/ContainerInfo.java b/test/smoke/framework/testCore/src/main/java/com/microsoft/applicationinsights/smoketest/docker/ContainerInfo.java
diff --git a/test/smoke/framework/utils/src/main/java/com/microsoft/applicationinsights/smoketest/telemetry/Duration.java b/test/smoke/framework/utils/src/main/java/com/microsoft/applicationinsights/smoketest/telemetry/Duration.java

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`import java.lang.management.ManagementFactory;`
`25`	`25`	`import java.lang.management.RuntimeMXBean;`
`26`	`26`	`import java.lang.reflect.Method;`
	`27`	`+import org.checkerframework.checker.nullness.qual.Nullable;`
`27`	`28`
`28`	`29`	`public class PidFinder extends CachedDiagnosticsValueFinder {`
`29`	`30`	`public static final String PROPERTY_NAME = "PID";`
`@@ -38,6 +39,7 @@ protected String populateValue() {`
`38`	`39`	`return getPidUsingRuntimeBean();`
`39`	`40`	`}`
`40`	`41`
	`42`	`+ @Nullable`
`41`	`43`	`private static String getPidUsingRuntimeBean() {`
`42`	`44`	`// will only work with sun based jvm`
`43`	`45`	`RuntimeMXBean rb = ManagementFactory.getRuntimeMXBean();`
`@@ -59,6 +61,7 @@ private static String getPidUsingRuntimeBean() {`
`59`	`61`	`}`
`60`	`62`	`}`
`61`	`63`
	`64`	`+ @Nullable`
`62`	`65`	`private static String getPidUsingProcessHandle() {`
`63`	`66`	`try {`
`64`	`67`	`// if java.specification.version < 9, the next line will fail.`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@`
`43`	`43`	`import java.util.concurrent.TimeUnit;`
`44`	`44`	`import okio.BufferedSink;`
`45`	`45`	`import okio.Okio;`
	`46`	`+import org.checkerframework.checker.nullness.qual.Nullable;`
`46`	`47`	`import org.slf4j.Logger;`
`47`	`48`	`import org.slf4j.LoggerFactory;`
`48`	`49`
`@@ -313,6 +314,7 @@ private static String getUniqueId(Object pid) {`
`313`	`314`	`}`
`314`	`315`	`}`
`315`	`316`
	`317`	`+ @Nullable`
`316`	`318`	`private static String capitalize(String input) {`
`317`	`319`	`if (input == null) {`
`318`	`320`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@`
`22`	`22`	`package com.microsoft.applicationinsights.alerting.config;`
`23`	`23`
`24`	`24`	`import java.util.Objects;`
	`25`	`+import org.checkerframework.checker.nullness.qual.Nullable;`
`25`	`26`
`26`	`27`	`/** Contains the overall configuration of the entire alerting subsystem. */`
`27`	`28`	`public class AlertingConfiguration {`
`@@ -66,7 +67,7 @@ public CollectionPlanConfiguration getCollectionPlanConfiguration() {`
`66`	`67`	`}`
`67`	`68`
`68`	`69`	`@Override`
`69`		`- public boolean equals(Object obj) {`
	`70`	`+ public boolean equals(@Nullable Object obj) {`
`70`	`71`	`if (obj == this) {`
`71`	`72`	`return true;`
`72`	`73`	`}`
`@@ -124,7 +125,7 @@ public long getCooldown() {`
`124`	`125`	`}`
`125`	`126`
`126`	`127`	`@Override`
`127`		`- public boolean equals(Object obj) {`
	`128`	`+ public boolean equals(@Nullable Object obj) {`
`128`	`129`	`if (obj == this) {`
`129`	`130`	`return true;`
`130`	`131`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@`
`23`	`23`
`24`	`24`	`import java.time.ZonedDateTime;`
`25`	`25`	`import java.util.Objects;`
	`26`	`+import org.checkerframework.checker.nullness.qual.Nullable;`
`26`	`27`
`27`	`28`	`public class CollectionPlanConfiguration {`
`28`	`29`
`@@ -81,7 +82,7 @@ public String getSettingsMoniker() {`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`@Override`
`84`		`- public boolean equals(Object obj) {`
	`85`	`+ public boolean equals(@Nullable Object obj) {`
`85`	`86`	`if (obj == this) {`
`86`	`87`	`return true;`
`87`	`88`	`}`