Update

Author: heyams

agent/agent-profiler/agent-diagnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java

@@ -26,7 +26,7 @@
 public class CGroupData extends Event implements JsonSerializable<CGroupData> {
 
   public static final String NAME = "com.microsoft.applicationinsights.diagnostics.jfr.CGroupData";
-  public static final int CGROUP_DATA_ABSENT = -2;
+  public static final int CGROUP_DATA_ABSENT = -2; // No CGroup data was found for this value
 
   // Limit of the kernel memory
   private long kmemLimit; // /sys/fs/cgroup/memory/memory.kmem.limit_in_bytes
@@ -108,9 +108,6 @@ public static CGroupData fromJson(JsonReader jsonReader) throws IOException {
           while (reader.nextToken() != JsonToken.END_OBJECT) {
             String fieldName = reader.getFieldName();
             reader.nextToken();
-            // In this case field names are case-sensitive but this could be replaced with
-            // 'equalsIgnoreCase' to
-            // make them case-insensitive.
             if ("kmemLimit".equals(fieldName)) {
               deserializedValue.setKmemLimit(reader.getLong());
             } else if ("memoryLimit".equals(fieldName)) {

agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/RequestAlertPipelineBuilderTest.java

@@ -24,16 +24,16 @@ public class RequestAlertPipelineBuilderTest {
 
   @Test
   public void configurationIsCorrectlyDuplicated() throws IOException {
-    Configuration.RequestTrigger expectedRequesttrigger = new Configuration.RequestTrigger();
-    expectedRequesttrigger.filter.type = Configuration.RequestFilterType.NAME_REGEX;
-    expectedRequesttrigger.filter.value = "foo.*";
-    expectedRequesttrigger.threshold.value = 0.75f;
+    Configuration.RequestTrigger expectedRequestTrigger = new Configuration.RequestTrigger();
+    expectedRequestTrigger.filter.type = Configuration.RequestFilterType.NAME_REGEX;
+    expectedRequestTrigger.filter.value = "foo.*";
+    expectedRequestTrigger.threshold.value = 0.75f;
 
     TestTimeSource timeSource = new TestTimeSource();
     timeSource.setNow(Instant.EPOCH);
 
     AlertingConfig.RequestTrigger config =
-        RequestAlertPipelineBuilder.buildRequestTriggerConfiguration(expectedRequesttrigger);
+        RequestAlertPipelineBuilder.buildRequestTriggerConfiguration(expectedRequestTrigger);
 
     String alertingConfigStr;
     try (StringWriter stringWriter = new StringWriter();
@@ -46,24 +46,24 @@ public void configurationIsCorrectlyDuplicated() throws IOException {
       actualAlertingConfig = AlertingConfig.RequestTrigger.fromJson(reader);
     }
 
-    Assertions.assertEquals(expectedRequesttrigger.name, actualAlertingConfig.name);
-    Assertions.assertEquals(expectedRequesttrigger.type.name(), actualAlertingConfig.type.name());
+    Assertions.assertEquals(expectedRequestTrigger.name, actualAlertingConfig.name);
+    Assertions.assertEquals(expectedRequestTrigger.type.name(), actualAlertingConfig.type.name());
     Assertions.assertEquals(
-        expectedRequesttrigger.filter.type.name(), actualAlertingConfig.filter.type.name());
-    Assertions.assertEquals(expectedRequesttrigger.filter.value, actualAlertingConfig.filter.value);
+        expectedRequestTrigger.filter.type.name(), actualAlertingConfig.filter.type.name());
+    Assertions.assertEquals(expectedRequestTrigger.filter.value, actualAlertingConfig.filter.value);
     Assertions.assertEquals(
-        expectedRequesttrigger.aggregation.type.name(),
+        expectedRequestTrigger.aggregation.type.name(),
         actualAlertingConfig.aggregation.type.name());
     Assertions.assertEquals(
-        expectedRequesttrigger.threshold.type.name(), actualAlertingConfig.threshold.type.name());
+        expectedRequestTrigger.threshold.type.name(), actualAlertingConfig.threshold.type.name());
     Assertions.assertEquals(
-        expectedRequesttrigger.threshold.value, actualAlertingConfig.threshold.value);
+        expectedRequestTrigger.threshold.value, actualAlertingConfig.threshold.value);
     Assertions.assertEquals(
-        expectedRequesttrigger.throttling.type.name(), actualAlertingConfig.throttling.type.name());
+        expectedRequestTrigger.throttling.type.name(), actualAlertingConfig.throttling.type.name());
     Assertions.assertEquals(
-        expectedRequesttrigger.throttling.value, actualAlertingConfig.throttling.value);
+        expectedRequestTrigger.throttling.value, actualAlertingConfig.throttling.value);
     Assertions.assertEquals(
-        expectedRequesttrigger.profileDuration, actualAlertingConfig.profileDuration);
+        expectedRequestTrigger.profileDuration, actualAlertingConfig.profileDuration);
   }
 
   @TestFactory