Fix EnumOrdinal ErrorProne violations by using explicit enum mapping instead of ordinal-based array access

Co-authored-by: trask <[email protected]>

Author: Copilot

buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts

@@ -73,10 +73,10 @@ tasks {
         // TimeInStaticInitializer check fixed - no longer disabled
 
         // New checks in ErrorProne 2.38.0 that we want to disable
-        disable("AddNullMarkedToPackageInfo")
+        disable("AddNullMarkedToPackageInfo") // requires JSpecify dependency not compatible with Java 8
 
         // Other new checks that cause warnings in our codebase
-        disable("EnumOrdinal")
+        // EnumOrdinal check fixed - no longer disabled
 
         if (name.contains("Jmh")) {
           disable("MemberName")

classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java

@@ -60,15 +60,14 @@ public void setSeverityLevel(SeverityLevel severityLevel) {
     data.setSeverityLevel(
         severityLevel == null
             ? null
-            : com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.values()[
-                severityLevel.getValue()]);
+            : mapToInternalSeverityLevel(severityLevel));
   }
 
   @Nullable
   public SeverityLevel getSeverityLevel() {
     return data.getSeverityLevel() == null
         ? null
-        : SeverityLevel.values()[data.getSeverityLevel().getValue()];
+        : mapFromInternalSeverityLevel(data.getSeverityLevel());
   }
 
   /** Gets a dictionary of custom defined metrics. */
@@ -80,4 +79,38 @@ public ConcurrentMap<String, Double> getMetrics() {
   protected ExceptionData getData() {
     return data;
   }
+
+  private static com.microsoft.applicationinsights.internal.schemav2.SeverityLevel mapToInternalSeverityLevel(SeverityLevel severityLevel) {
+    switch (severityLevel) {
+      case Verbose:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Verbose;
+      case Information:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Information;
+      case Warning:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Warning;
+      case Error:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Error;
+      case Critical:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Critical;
+      default:
+        throw new IllegalArgumentException("Unknown SeverityLevel: " + severityLevel);
+    }
+  }
+
+  private static SeverityLevel mapFromInternalSeverityLevel(com.microsoft.applicationinsights.internal.schemav2.SeverityLevel internalSeverityLevel) {
+    switch (internalSeverityLevel) {
+      case Verbose:
+        return SeverityLevel.Verbose;
+      case Information:
+        return SeverityLevel.Information;
+      case Warning:
+        return SeverityLevel.Warning;
+      case Error:
+        return SeverityLevel.Error;
+      case Critical:
+        return SeverityLevel.Critical;
+      default:
+        throw new IllegalArgumentException("Unknown internal SeverityLevel: " + internalSeverityLevel);
+    }
+  }
 }

classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java

@@ -51,19 +51,52 @@ public void setSeverityLevel(SeverityLevel severityLevel) {
     data.setSeverityLevel(
         severityLevel == null
             ? null
-            : com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.values()[
-                severityLevel.getValue()]);
+            : mapToInternalSeverityLevel(severityLevel));
   }
 
   @Nullable
   public SeverityLevel getSeverityLevel() {
     return data.getSeverityLevel() == null
         ? null
-        : SeverityLevel.values()[data.getSeverityLevel().getValue()];
+        : mapFromInternalSeverityLevel(data.getSeverityLevel());
   }
 
   @Override
   protected MessageData getData() {
     return data;
   }
+
+  private static com.microsoft.applicationinsights.internal.schemav2.SeverityLevel mapToInternalSeverityLevel(SeverityLevel severityLevel) {
+    switch (severityLevel) {
+      case Verbose:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Verbose;
+      case Information:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Information;
+      case Warning:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Warning;
+      case Error:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Error;
+      case Critical:
+        return com.microsoft.applicationinsights.internal.schemav2.SeverityLevel.Critical;
+      default:
+        throw new IllegalArgumentException("Unknown SeverityLevel: " + severityLevel);
+    }
+  }
+
+  private static SeverityLevel mapFromInternalSeverityLevel(com.microsoft.applicationinsights.internal.schemav2.SeverityLevel internalSeverityLevel) {
+    switch (internalSeverityLevel) {
+      case Verbose:
+        return SeverityLevel.Verbose;
+      case Information:
+        return SeverityLevel.Information;
+      case Warning:
+        return SeverityLevel.Warning;
+      case Error:
+        return SeverityLevel.Error;
+      case Critical:
+        return SeverityLevel.Critical;
+      default:
+        throw new IllegalArgumentException("Unknown internal SeverityLevel: " + internalSeverityLevel);
+    }
+  }
 }