an implementation that builds

Author: harsimar

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentSpanExporter.java

@@ -8,7 +8,6 @@
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.SpanDataMapper;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.logging.OperationLogger;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.models.TelemetryItem;
-import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.QuickPulse;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.utils.Strings;
 import com.microsoft.applicationinsights.agent.internal.telemetry.BatchItemProcessor;
 import com.microsoft.applicationinsights.agent.internal.telemetry.TelemetryClient;
@@ -18,7 +17,6 @@
 import io.opentelemetry.sdk.trace.export.SpanExporter;
 import java.util.Collection;
 import java.util.function.Consumer;
-import javax.annotation.Nullable;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/RuntimeConfigurator.java

@@ -138,7 +138,7 @@ public void apply(RuntimeConfiguration runtimeConfig) {
         || !Objects.equals(runtimeConfig.sampling.percentage, currentConfig.sampling.percentage)
         || !Objects.equals(
             runtimeConfig.sampling.requestsPerSecond, currentConfig.sampling.requestsPerSecond)) {
-      updateSampling(enabled, runtimeConfig.sampling, runtimeConfig.samplingPreview, null);
+      updateSampling(enabled, runtimeConfig.sampling, runtimeConfig.samplingPreview, telemetryClient.getQuickPulse());
     }
 
     // initialize Profiler

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java

@@ -167,6 +167,28 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
 
     TelemetryClient.setActive(telemetryClient);
 
+    QuickPulse quickPulse;
+    if (configuration.preview.liveMetrics.enabled) {
+      quickPulse =
+          QuickPulse.create(
+              LazyHttpClient.newHttpPipeLineWithDefaultRedirect(configuration.authentication),
+              () -> {
+                ConnectionString connectionString = telemetryClient.getConnectionString();
+                return connectionString == null ? null : connectionString.getLiveEndpoint();
+              },
+              telemetryClient::getInstrumentationKey,
+              telemetryClient.getRoleName(),
+              telemetryClient.getRoleInstance(),
+              FirstEntryPoint.getAgentVersion());
+    } else {
+      quickPulse = null;
+    }
+    // quickPulse needs to be set before the runtimeConfigurator is created, so that when
+    // the telemetry client is passed to the runtime configurator, the runtime configurator can
+    // use it to pass quickPulse to the RuntimeConfigurator.updateSampling method. Sampling may
+    // use quickPulse.isEnabled to determine if telemetry should be dropped or record only.
+    telemetryClient.setQuickPulse(quickPulse);
+
     // TODO (heya) remove duplicate code in both RuntimeConfigurator and SecondEntryPoint
     RuntimeConfigurator runtimeConfigurator =
         new RuntimeConfigurator(
@@ -221,24 +243,6 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
     // TODO (trask) add this method to AutoConfigurationCustomizer upstream?
     ((AutoConfiguredOpenTelemetrySdkBuilder) autoConfiguration).disableShutdownHook();
 
-    QuickPulse quickPulse;
-    if (configuration.preview.liveMetrics.enabled) {
-      quickPulse =
-          QuickPulse.create(
-              LazyHttpClient.newHttpPipeLineWithDefaultRedirect(configuration.authentication),
-              () -> {
-                ConnectionString connectionString = telemetryClient.getConnectionString();
-                return connectionString == null ? null : connectionString.getLiveEndpoint();
-              },
-              telemetryClient::getInstrumentationKey,
-              telemetryClient.getRoleName(),
-              telemetryClient.getRoleInstance(),
-              FirstEntryPoint.getAgentVersion());
-    } else {
-      quickPulse = null;
-    }
-    telemetryClient.setQuickPulse(quickPulse);
-
     AtomicBoolean firstLogRecordProcessor = new AtomicBoolean(true);
 
 

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/AiSampler.java

@@ -30,7 +30,7 @@ public class AiSampler implements Sampler {
   private final SamplingPercentage parentlessDependencySamplingPercentage;
   private final boolean ingestionSamplingEnabled;
   private static final ClientLogger logger = new ClientLogger(AiSampler.class);
-  private static QuickPulse quickPulse;
+  private final QuickPulse quickPulse;
 
   public static AiSampler create(
       SamplingPercentage requestSamplingPercentage,
@@ -52,7 +52,7 @@ private AiSampler(
     this.requestSamplingPercentage = requestSamplingPercentage;
     this.parentlessDependencySamplingPercentage = parentlessDependencySamplingPercentage;
     this.ingestionSamplingEnabled = ingestionSamplingEnabled;
-    AiSampler.quickPulse = quickPulse;
+    this.quickPulse = quickPulse;
   }
 
   @Override
@@ -107,7 +107,7 @@ public SamplingResult shouldSample(
   }
 
   @Nullable
-  private static SamplingResult useLocalParentDecisionIfPossible(
+  private SamplingResult useLocalParentDecisionIfPossible(
       SpanContext parentSpanContext, @Nullable Double parentSpanSampleRate) {
 
     // remote parent-based sampling messes up item counts since item count is not propagated in

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/telemetry/TelemetryClient.java

@@ -424,6 +424,10 @@ public void setQuickPulse(@Nullable QuickPulse quickPulse) {
     this.quickPulse = quickPulse;
   }
 
+  public QuickPulse getQuickPulse() {
+    return quickPulse;
+  }
+
   public void setOtelResource(Resource resource) {
     otelResource = resource;
   }