fix

Author: trask

smoke-tests/apps/AzureFunctions/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/ConsumptionPlanDisabledTest.java

@@ -24,9 +24,12 @@ abstract class ConsumptionPlanDisabledTest {
   static final SmokeTestExtension testing =
       SmokeTestExtension.builder()
           .doNotSetConnectionString()
+          .setSkipHealthCheck(true)
           .setEnvVar("FUNCTIONS_WORKER_RUNTIME", "java")
           .setEnvVar("APPLICATIONINSIGHTS_ENABLE_AGENT", "false")
-          .setSkipHealthCheck(true)
+          // need to --add-opens for Java 17+ in order to set env var at runtime in SpringBootApp
+          .addJvmArg("-XX:+IgnoreUnrecognizedVMOptions")
+          .addJvmArg("--add-opens=java.base/java.util=ALL-UNNAMED")
           .build();
 
   @Test

smoke-tests/apps/AzureFunctions/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/ConsumptionPlanEnabledTest.java

@@ -24,9 +24,12 @@ abstract class ConsumptionPlanEnabledTest {
   static final SmokeTestExtension testing =
       SmokeTestExtension.builder()
           .doNotSetConnectionString()
+          .setSkipHealthCheck(true) // to be consistent with the disabled test
           .setEnvVar("FUNCTIONS_WORKER_RUNTIME", "java")
           .setEnvVar("APPLICATIONINSIGHTS_ENABLE_AGENT", "true")
-          .setSkipHealthCheck(true) // to be consistent with the disabled test
+          // need to --add-opens for Java 17+ in order to set env var at runtime in SpringBootApp
+          .addJvmArg("-XX:+IgnoreUnrecognizedVMOptions")
+          .addJvmArg("--add-opens=java.base/java.util=ALL-UNNAMED")
           .build();
 
   @Test

smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java

@@ -105,6 +105,7 @@ public class SmokeTestExtension
   private final File agentExtensionFile;
   private final Map<String, String> httpHeaders;
   private final Map<String, String> envVars;
+  private final List<String> jvmArgs;
   private final boolean useDefaultHttpPort;
   private final boolean useOtlpEndpoint;
 
@@ -130,6 +131,7 @@ public static SmokeTestExtensionBuilder builder() {
       ProfilerState profilerState,
       Map<String, String> httpHeaders,
       Map<String, String> envVars,
+      List<String> jvmArgs,
       boolean useDefaultHttpPort,
       boolean useOtlpEndpoint) {
     this.skipHealthCheck = skipHealthCheck;
@@ -158,6 +160,7 @@ public static SmokeTestExtensionBuilder builder() {
 
     this.httpHeaders = httpHeaders;
     this.envVars = envVars;
+    this.jvmArgs = jvmArgs;
     this.useDefaultHttpPort = useDefaultHttpPort;
     this.useOtlpEndpoint = useOtlpEndpoint;
   }
@@ -486,7 +489,12 @@ private void startTestApplicationContainer() throws Exception {
     }
 
     if (appFile.getName().endsWith(".jar")) {
-      container = container.withCommand("java -jar " + appFile.getName());
+      List<String> parts = new ArrayList<>();
+      parts.add("java");
+      parts.addAll(jvmArgs);
+      parts.add("-jar");
+      parts.add(appFile.getName());
+      container = container.withCommand(parts.toArray(new String[0]));
     }
 
     if (readOnly) {

smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtensionBuilder.java

@@ -5,7 +5,9 @@
 
 import com.microsoft.applicationinsights.smoketest.fakeingestion.ProfilerState;
 import java.io.File;
+import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.List;
 import java.util.Map;
 import org.testcontainers.containers.GenericContainer;
 
@@ -24,6 +26,7 @@ public class SmokeTestExtensionBuilder {
   private ProfilerState profilerEndpointPath = ProfilerState.unconfigured;
   private final Map<String, String> httpHeaders = new HashMap<>();
   private final Map<String, String> envVars = new HashMap<>();
+  private final List<String> jvmArgs = new ArrayList<>();
   private boolean useDefaultHttpPort;
   private boolean useOtlpEndpoint;
 
@@ -90,6 +93,11 @@ public SmokeTestExtensionBuilder setEnvVar(String name, String value) {
     return this;
   }
 
+  public SmokeTestExtensionBuilder addJvmArg(String jvmArg) {
+    jvmArgs.add(jvmArg);
+    return this;
+  }
+
   public SmokeTestExtensionBuilder setUseDefaultHttpPort() {
     this.useDefaultHttpPort = true;
     return this;
@@ -115,6 +123,7 @@ public SmokeTestExtension build() {
         profilerEndpointPath,
         httpHeaders,
         envVars,
+        jvmArgs,
         useDefaultHttpPort,
         useOtlpEndpoint);
   }