Skip to content

Commit 3e02339

Browse files
authored
More smoke test cleanup (#1864)
* More smoke test cleanup * Fix * Fix variable port assignment * Fix
1 parent fe34228 commit 3e02339

File tree

20 files changed

+79
-33
lines changed

20 files changed

+79
-33
lines changed

test/smoke/testApps/AzureSdk/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/AzureSdkDisabledTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,9 @@ public void test() throws Exception {
3535
Telemetry telemetry = getTelemetry(1);
3636

3737
assertEquals("GET /AzureSdk/test", telemetry.rd.getName());
38-
assertTrue(telemetry.rd.getProperties().isEmpty());
3938
assertTrue(telemetry.rd.getSuccess());
4039

4140
assertEquals("TestController.test", telemetry.rdd1.getName());
42-
assertTrue(telemetry.rdd1.getProperties().isEmpty());
4341
assertTrue(telemetry.rdd1.getSuccess());
4442

4543
assertParentChild(

test/smoke/testApps/AzureSdk/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/AzureSdkTest.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
package com.microsoft.applicationinsights.smoketest;
2323

2424
import static org.junit.Assert.assertEquals;
25+
import static org.junit.Assert.assertNull;
2526
import static org.junit.Assert.assertTrue;
2627

2728
import com.microsoft.applicationinsights.smoketest.schemav2.Envelope;
@@ -47,14 +48,21 @@ public void test() throws Exception {
4748
}
4849

4950
assertEquals("GET /AzureSdk/test", telemetry.rd.getName());
50-
assertTrue(telemetry.rd.getProperties().isEmpty());
51+
assertTrue(telemetry.rd.getUrl().matches("http://localhost:[0-9]+/AzureSdk/test"));
52+
assertEquals("200", telemetry.rd.getResponseCode());
5153
assertTrue(telemetry.rd.getSuccess());
54+
assertNull(telemetry.rd.getSource());
55+
assertTrue(telemetry.rd.getProperties().isEmpty());
56+
assertTrue(telemetry.rd.getMeasurements().isEmpty());
5257

5358
assertEquals("TestController.test", telemetry.rdd1.getName());
59+
assertEquals("InProc", telemetry.rdd1.getType());
60+
assertNull(telemetry.rdd1.getTarget());
5461
assertTrue(telemetry.rdd1.getProperties().isEmpty());
5562
assertTrue(telemetry.rdd1.getSuccess());
5663

5764
assertEquals("hello", telemetry.rdd2.getName());
65+
assertEquals("InProc", telemetry.rdd2.getType());
5866
assertTrue(telemetry.rdd2.getProperties().isEmpty());
5967
assertTrue(telemetry.rdd2.getSuccess());
6068

test/smoke/testApps/Cassandra/src/smokeTest/java/com/microsoft/applicationinsights/smoketestapp/CassandraDisabledTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ public void cassandra() throws Exception {
4545
Telemetry telemetry = getTelemetry(0);
4646

4747
assertEquals("GET /Cassandra/*", telemetry.rd.getName());
48-
assertEquals("200", telemetry.rd.getResponseCode());
49-
assertTrue(telemetry.rd.getProperties().isEmpty());
5048
assertTrue(telemetry.rd.getSuccess());
5149

5250
// sleep a bit and make sure no cassandra dependencies are reported

test/smoke/testApps/Cassandra/src/smokeTest/java/com/microsoft/applicationinsights/smoketestapp/CassandraTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
package com.microsoft.applicationinsights.smoketestapp;
2323

2424
import static org.junit.Assert.assertEquals;
25+
import static org.junit.Assert.assertNull;
2526
import static org.junit.Assert.assertTrue;
2627

2728
import com.microsoft.applicationinsights.smoketest.AiSmokeTest;
@@ -45,9 +46,12 @@ public void cassandra() throws Exception {
4546
Telemetry telemetry = getTelemetry(1);
4647

4748
assertEquals("GET /Cassandra/*", telemetry.rd.getName());
49+
assertTrue(telemetry.rd.getUrl().matches("http://localhost:[0-9]+/Cassandra/cassandra"));
4850
assertEquals("200", telemetry.rd.getResponseCode());
49-
assertTrue(telemetry.rd.getProperties().isEmpty());
5051
assertTrue(telemetry.rd.getSuccess());
52+
assertNull(telemetry.rd.getSource());
53+
assertTrue(telemetry.rd.getProperties().isEmpty());
54+
assertTrue(telemetry.rd.getMeasurements().isEmpty());
5155

5256
assertEquals("SELECT test.test", telemetry.rdd1.getName());
5357
assertEquals("cassandra", telemetry.rdd1.getType());

test/smoke/testApps/Jdbc/src/smokeTest/java/com/microsoft/applicationinsights/smoketestapp/JdbcDisabledTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ public void hsqldbPreparedStatement() throws Exception {
3838
Telemetry telemetry = getTelemetry(0);
3939

4040
assertEquals("GET /Jdbc/*", telemetry.rd.getName());
41-
assertEquals("200", telemetry.rd.getResponseCode());
42-
assertTrue(telemetry.rd.getProperties().isEmpty());
4341
assertTrue(telemetry.rd.getSuccess());
4442

4543
// sleep a bit and make sure no jdbc dependencies are reported

test/smoke/testApps/Jedis/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JedisDisabledTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ public void jedis() throws Exception {
3636
Telemetry telemetry = getTelemetry(0);
3737

3838
assertEquals("GET /Jedis/*", telemetry.rd.getName());
39-
assertEquals("200", telemetry.rd.getResponseCode());
40-
assertTrue(telemetry.rd.getProperties().isEmpty());
4139
assertTrue(telemetry.rd.getSuccess());
4240

4341
// sleep a bit and make sure no jedis dependencies are reported

test/smoke/testApps/Jedis/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JedisTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
package com.microsoft.applicationinsights.smoketest;
2323

2424
import static org.junit.Assert.assertEquals;
25+
import static org.junit.Assert.assertNull;
2526
import static org.junit.Assert.assertTrue;
2627

2728
import org.junit.Test;
@@ -36,9 +37,12 @@ public void jedis() throws Exception {
3637
Telemetry telemetry = getTelemetry(1);
3738

3839
assertEquals("GET /Jedis/*", telemetry.rd.getName());
40+
assertTrue(telemetry.rd.getUrl().matches("http://localhost:[0-9]+/Jedis/jedis"));
3941
assertEquals("200", telemetry.rd.getResponseCode());
40-
assertTrue(telemetry.rd.getProperties().isEmpty());
4142
assertTrue(telemetry.rd.getSuccess());
43+
assertNull(telemetry.rd.getSource());
44+
assertTrue(telemetry.rd.getProperties().isEmpty());
45+
assertTrue(telemetry.rd.getMeasurements().isEmpty());
4246

4347
assertEquals("GET", telemetry.rdd1.getName());
4448
assertEquals("redis", telemetry.rdd1.getType());

test/smoke/testApps/JettyNativeHandler/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/JettyNativeHandlerTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
package com.microsoft.applicationinsights.smoketest;
2323

2424
import static org.junit.Assert.assertEquals;
25+
import static org.junit.Assert.assertNull;
2526
import static org.junit.Assert.assertTrue;
2627

2728
import org.junit.Test;
@@ -35,8 +36,11 @@ public void doSimpleTest() throws Exception {
3536
Telemetry telemetry = getTelemetry(0);
3637

3738
assertEquals("HTTP GET", telemetry.rd.getName());
39+
assertTrue(telemetry.rd.getUrl().matches("http://localhost:[0-9]+/path"));
3840
assertEquals("200", telemetry.rd.getResponseCode());
39-
assertTrue(telemetry.rd.getProperties().isEmpty());
4041
assertTrue(telemetry.rd.getSuccess());
42+
assertNull(telemetry.rd.getSource());
43+
assertTrue(telemetry.rd.getProperties().isEmpty());
44+
assertTrue(telemetry.rd.getMeasurements().isEmpty());
4145
}
4246
}

test/smoke/testApps/Lettuce/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/LettuceDisabledTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ public void lettuce() throws Exception {
3636
Telemetry telemetry = getTelemetry(0);
3737

3838
assertEquals("GET /Lettuce/*", telemetry.rd.getName());
39-
assertEquals("200", telemetry.rd.getResponseCode());
40-
assertTrue(telemetry.rd.getProperties().isEmpty());
4139
assertTrue(telemetry.rd.getSuccess());
4240

4341
// sleep a bit and make sure no lettuce dependencies are reported

test/smoke/testApps/Lettuce/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/LettuceTest.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
package com.microsoft.applicationinsights.smoketest;
2323

2424
import static org.junit.Assert.assertEquals;
25+
import static org.junit.Assert.assertNull;
2526
import static org.junit.Assert.assertTrue;
2627

2728
import org.junit.Test;
@@ -36,9 +37,12 @@ public void lettuce() throws Exception {
3637
Telemetry telemetry = getTelemetry(1);
3738

3839
assertEquals("GET /Lettuce/*", telemetry.rd.getName());
40+
assertTrue(telemetry.rd.getUrl().matches("http://localhost:[0-9]+/Lettuce/lettuce"));
3941
assertEquals("200", telemetry.rd.getResponseCode());
40-
assertTrue(telemetry.rd.getProperties().isEmpty());
4142
assertTrue(telemetry.rd.getSuccess());
43+
assertNull(telemetry.rd.getSource());
44+
assertTrue(telemetry.rd.getProperties().isEmpty());
45+
assertTrue(telemetry.rd.getMeasurements().isEmpty());
4246

4347
assertEquals("GET", telemetry.rdd1.getName());
4448
assertEquals("redis", telemetry.rdd1.getType());

0 commit comments

Comments
 (0)