Merge pull request #415 from Microsoft/dhaval/RevertSetSampleRateNullCheck

Dhaval/revert set sample rate null check

Author: Dmitry-Matveev

CHANGELOG.md

@@ -1,6 +1,7 @@
 # CHANGELOG
 
 ## Version 1.0.10
+- Fixed Request Telemetry Sending bug with new schema
 - Schema updated to the latest version. Changes in internal namespace `core/src/main/java/com/microsoft/applicationinsights/internal/schemav2`.
 - Class `SendableData` in internal namespace deleted.
 - Class `com.microsoft.applicationinsights.telemetry.BaseSampleSourceTelemetry` takes generic class qualifier `Domain` instead of `SendableData`.

core/src/main/java/com/microsoft/applicationinsights/internal/schemav2/Envelope.java

@@ -140,7 +140,7 @@ public double getSampleRate() {
      * Sets the SampleRate property.
      */
     public void setSampleRate(double value) {
-        this.sampleRate = value;
+            this.sampleRate = value;
     }
 
     /**

core/src/main/java/com/microsoft/applicationinsights/telemetry/BaseSampleSourceTelemetry.java

@@ -17,6 +17,8 @@ public void reset() {
     @Override
     protected void setSampleRate(Envelope envelope) {
         Double currentSP = getSamplingPercentage();
-        envelope.setSampleRate(currentSP);
+        if (currentSP != null) {
+            envelope.setSampleRate(currentSP);
+        }
     }
 }

core/src/main/java/com/microsoft/applicationinsights/telemetry/JsonTelemetryDataSerializer.java

@@ -69,7 +69,7 @@ public void close() throws IOException {
 
     public void write(String name, Duration value) throws IOException {
         writeName(name);
-        out.write(String.valueOf(value));
+        write(String.valueOf(value));
         separator = JSON_SEPARATOR;
     }