Set resultCode to zero when Span.httpStatusCode is not present (#2925)

heyams · web-flow · commit 43418903187a · 2023-02-22T07:46:13.000-08:00
https://1dsdocs.azurewebsites.net/schema/Mappings/AzureMonitor-AI.html#remotedependencyresultcode
diff --git a/agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java b/agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
@@ -300,6 +300,9 @@ private static void applyHttpClientSpan(
     Long httpStatusCode = attributes.get(SemanticAttributes.HTTP_STATUS_CODE);
     if (httpStatusCode != null) {
       telemetryBuilder.setResultCode(Long.toString(httpStatusCode));
+    } else {
+      // https://1dsdocs.azurewebsites.net/schema/Mappings/AzureMonitor-AI.html#remotedependencyresultcode
+      telemetryBuilder.setResultCode("0");
     }
 
     telemetryBuilder.setData(httpUrl);

Original file line number	Diff line number	Diff line change
`@@ -300,6 +300,9 @@ private static void applyHttpClientSpan(`
`300`	`300`	`Long httpStatusCode = attributes.get(SemanticAttributes.HTTP_STATUS_CODE);`
`301`	`301`	`if (httpStatusCode != null) {`
`302`	`302`	`telemetryBuilder.setResultCode(Long.toString(httpStatusCode));`
	`303`	`+ } else {`
	`304`	`+ // https://1dsdocs.azurewebsites.net/schema/Mappings/AzureMonitor-AI.html#remotedependencyresultcode`
	`305`	`+ telemetryBuilder.setResultCode("0");`
`303`	`306`	`}`
`304`	`307`
`305`	`308`	`telemetryBuilder.setData(httpUrl);`