Fix ErrorProne 2.38.0 build failures by updating checker configuration (#4257)

Copilot · trask · web-flow · commit 4cf74cad57ee · 2025-07-09T07:08:55.000-07:00
Co-authored-by: copilot-swe-agent[bot] &lt;198982749+Copilot@users.noreply.github.com&gt;
Co-authored-by: trask &lt;218610+trask@users.noreply.github.com&gt;
Co-authored-by: Trask Stalnaker &lt;trask.stalnaker@gmail.com&gt;
diff --git a/agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java b/agent/agent-profiler/agent-alerting/src/test/java/com/microsoft/applicationinsights/alerting/AlertingSubsystemTest.java
@@ -30,14 +30,14 @@ private static AlertingSubsystem getAlertMonitor(
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build(),
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build(),
@@ -89,14 +89,14 @@ void manualAlertWorks() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build(),
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build(),
@@ -130,14 +130,14 @@ void manualAlertDoesNotTriggerAfterExpired() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build(),
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build(),
diff --git a/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java b/agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/profiler/triggers/AlertConfigParserTest.java
@@ -43,7 +43,7 @@ void saneDataIsParsed() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.CPU)
                 .setEnabled(true)
-                .setThreshold((float) 80)
+                .setThreshold(80.0f)
                 .setProfileDurationSeconds(30)
                 .setCooldownSeconds(14400)
                 .build());
@@ -53,7 +53,7 @@ void saneDataIsParsed() {
             AlertConfiguration.builder()
                 .setType(AlertMetricType.MEMORY)
                 .setEnabled(true)
-                .setThreshold((float) 20)
+                .setThreshold(20.0f)
                 .setProfileDurationSeconds(120)
                 .setCooldownSeconds(14400)
                 .build());
diff --git a/buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts b/buildSrc/src/main/kotlin/ai.errorprone-conventions.gradle.kts
@@ -54,7 +54,6 @@ tasks {
 
         // Don't support Android without desugar
         disable("AndroidJdkLibsChecker")
-        disable("Java7ApiChecker")
         disable("StaticOrDefaultInterfaceMethod")
 
         // needed temporarily while hosting azure-monitor-opentelemetry-exporter in this repo
@@ -70,6 +69,9 @@ tasks {
         // cognitive load is dubious.
         disable("YodaCondition")
 
+        // Requires adding compile dependency to JSpecify
+        disable("AddNullMarkedToPackageInfo")
+
         if (name.contains("Jmh")) {
           disable("MemberName")
         }
diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/ExceptionTelemetry.java
@@ -56,6 +56,7 @@ public void setException(Throwable throwable, int stackSize) {
     this.throwable = throwable;
   }
 
+  @SuppressWarnings("EnumOrdinal")
   public void setSeverityLevel(SeverityLevel severityLevel) {
     data.setSeverityLevel(
         severityLevel == null
@@ -65,6 +66,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) {
   }
 
   @Nullable
+  @SuppressWarnings("EnumOrdinal")
   public SeverityLevel getSeverityLevel() {
     return data.getSeverityLevel() == null
         ? null
diff --git a/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java b/classic-sdk/core/src/main/java/com/microsoft/applicationinsights/telemetry/TraceTelemetry.java
@@ -47,6 +47,7 @@ public void setMessage(String message) {
     data.setMessage(message);
   }
 
+  @SuppressWarnings("EnumOrdinal")
   public void setSeverityLevel(SeverityLevel severityLevel) {
     data.setSeverityLevel(
         severityLevel == null
@@ -56,6 +57,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) {
   }
 
   @Nullable
+  @SuppressWarnings("EnumOrdinal")
   public SeverityLevel getSeverityLevel() {
     return data.getSeverityLevel() == null
         ? null
diff --git a/dependencyManagement/build.gradle.kts b/dependencyManagement/build.gradle.kts
@@ -33,7 +33,7 @@ val DEPENDENCY_BOMS = listOf(
 
 val autoServiceVersion = "1.1.1"
 val autoValueVersion = "1.11.0"
-val errorProneVersion = "2.36.0"
+val errorProneVersion = "2.38.0"
 val jmhVersion = "1.37"
 val mockitoVersion = "4.11.0"
 val slf4jVersion = "2.0.17"
diff --git a/licenses/more-licenses.md b/licenses/more-licenses.md
@@ -36,7 +36,7 @@ _2025-07-08 14:53:50 UTC_
 > - **POM Project URL**: [http://stephenc.github.com/jcip-annotations](http://stephenc.github.com/jcip-annotations)
 > - **POM License**: Apache License, Version 2.0 - [https://www.apache.org/licenses/LICENSE-2.0](https://www.apache.org/licenses/LICENSE-2.0)
 
-**6** **Group:** `com.google.errorprone` **Name:** `error_prone_annotations` **Version:** `2.36.0` 
+**6** **Group:** `com.google.errorprone` **Name:** `error_prone_annotations` **Version:** `2.38.0` 
 > - **Manifest Project URL**: [https://errorprone.info/error_prone_annotations](https://errorprone.info/error_prone_annotations)
 > - **Manifest License**: Apache License, Version 2.0 (Not Packaged)
 > - **POM License**: Apache License, Version 2.0 - [http://www.apache.org/licenses/LICENSE-2.0](http://www.apache.org/licenses/LICENSE-2.0)
diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedProfilerSettingsServlet.java
@@ -15,6 +15,7 @@
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
+@SuppressWarnings("TimeInStaticInitializer")
 public class MockedProfilerSettingsServlet extends HttpServlet {
 
   private static final Map<ProfilerState, String> CONFIGS;

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,7 @@ public void setException(Throwable throwable, int stackSize) {`
`56`	`56`	`this.throwable = throwable;`
`57`	`57`	`}`
`58`	`58`
	`59`	`+ @SuppressWarnings("EnumOrdinal")`
`59`	`60`	`public void setSeverityLevel(SeverityLevel severityLevel) {`
`60`	`61`	`data.setSeverityLevel(`
`61`	`62`	`severityLevel == null`
`@@ -65,6 +66,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) {`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`@Nullable`
	`69`	`+ @SuppressWarnings("EnumOrdinal")`
`68`	`70`	`public SeverityLevel getSeverityLevel() {`
`69`	`71`	`return data.getSeverityLevel() == null`
`70`	`72`	`? null`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ public void setMessage(String message) {`
`47`	`47`	`data.setMessage(message);`
`48`	`48`	`}`
`49`	`49`
	`50`	`+ @SuppressWarnings("EnumOrdinal")`
`50`	`51`	`public void setSeverityLevel(SeverityLevel severityLevel) {`
`51`	`52`	`data.setSeverityLevel(`
`52`	`53`	`severityLevel == null`
`@@ -56,6 +57,7 @@ public void setSeverityLevel(SeverityLevel severityLevel) {`
`56`	`57`	`}`
`57`	`58`
`58`	`59`	`@Nullable`
	`60`	`+ @SuppressWarnings("EnumOrdinal")`
`59`	`61`	`public SeverityLevel getSeverityLevel() {`
`60`	`62`	`return data.getSeverityLevel() == null`
`61`	`63`	`? null`