account for null connection string

Author: harsimar

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java

@@ -202,7 +202,7 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
       statsbeatModule.start(
           AzureMonitorHelper.createStatsbeatTelemetryItemExporter(
               LazyHttpClient.newHttpPipeLine(
-                  null, telemetryClient.getConnectionString().getAadAudienceWithScope()),
+                  null, telemetryClient.getAadAudienceWithScope()),
               statsbeatModule,
               tempDir),
           telemetryClient::getStatsbeatConnectionString,
@@ -229,8 +229,8 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
           QuickPulse.create(
               LazyHttpClient.newHttpPipeLineWithDefaultRedirect(
                   configuration.authentication,
-                  telemetryClient.getConnectionString().getAadAudienceWithScope()),
-              () -> {
+                  telemetryClient.getAadAudienceWithScope()),
+                  () -> {
                 ConnectionString connectionString = telemetryClient.getConnectionString();
                 return connectionString == null ? null : connectionString.getLiveEndpoint();
               },

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializer.java

@@ -121,7 +121,7 @@ private synchronized void performInit() {
     httpPipeline =
         LazyHttpClient.newHttpPipeLine(
             telemetryClient.getAadAuthentication(),
-            telemetryClient.getConnectionString().getAadAudienceWithScope(),
+            telemetryClient.getAadAudienceWithScope(),
             new RedirectPolicy(
                 new DefaultRedirectStrategy(
                     3,

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/telemetry/TelemetryClient.java

@@ -85,6 +85,9 @@ public class TelemetryClient {
   @Nullable private volatile BatchItemProcessor metricsBatchItemProcessor;
   @Nullable private volatile BatchItemProcessor statsbeatBatchItemProcessor;
 
+  private static final String APPLICATIONINSIGHTS_AUTHENTICATION_SCOPE =
+      "https://monitor.azure.com//.default";
+
   public static TelemetryClient.Builder builder() {
     return new TelemetryClient.Builder();
   }
@@ -223,11 +226,12 @@ public BatchItemProcessor getMetricsBatchItemProcessor() {
 
   private BatchItemProcessor initBatchItemProcessor(
       int exportQueueCapacity, int maxExportBatchSize, String queueName) {
-
+    //logger.info("Connection string telemetryclient: {}", connectionString.getOriginalString());
+    //logger.info("Statsbeat connection string telemetryclient: {}", statsbeatConnectionString.getInstrumentationKey());
     HttpPipeline httpPipeline =
         LazyHttpClient.newHttpPipeLine(
             aadAuthentication,
-            connectionString.getAadAudienceWithScope(),
+            getAadAudienceWithScope(),
             new NetworkStatsbeatHttpPipelinePolicy(statsbeatModule.getNetworkStatsbeat()));
     // TODO (heya) refactor the following by using AzureMonitorHelper.createTelemetryItemExporter by
     // passing in getNonessentialStatsbeat
@@ -354,6 +358,13 @@ public ConnectionString getConnectionString() {
     return connectionString;
   }
 
+  public String getAadAudienceWithScope() {
+    if (connectionString == null) {
+      return APPLICATIONINSIGHTS_AUTHENTICATION_SCOPE;
+    }
+    return connectionString.getAadAudienceWithScope();
+  }
+
   @Nullable
   public String getRoleName() {
     return roleName;