Fix and properly test azure function integration

trask · trask · commit 819b29588ad0 · 2025-02-18T20:33:12.000-08:00
diff --git a/agent/agent-tooling/build.gradle.kts b/agent/agent-tooling/build.gradle.kts
@@ -24,6 +24,7 @@ dependencies {
   implementation("com.azure:azure-monitor-opentelemetry-autoconfigure:1.0.0-beta.2")
   compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-bootstrap")
   compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling")
+  compileOnly("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling-java9")
   compileOnly("io.opentelemetry.javaagent.instrumentation:opentelemetry-javaagent-servlet-common-bootstrap")
   testImplementation("io.opentelemetry.javaagent:opentelemetry-javaagent-tooling")
 
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/AzureFunctionsInitializer.java
@@ -5,8 +5,11 @@
 
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.utils.Strings;
 import com.microsoft.applicationinsights.agent.internal.diagnostics.DiagnosticsHelper;
-import io.opentelemetry.javaagent.bootstrap.ClassFileTransformerHolder;
 import io.opentelemetry.javaagent.bootstrap.InstrumentationHolder;
+import io.opentelemetry.javaagent.bootstrap.LambdaTransformer;
+import io.opentelemetry.javaagent.bootstrap.LambdaTransformerHolder;
+import io.opentelemetry.javaagent.tooling.Java8LambdaTransformer;
+import io.opentelemetry.javaagent.tooling.Java9LambdaTransformer;
 import java.lang.instrument.ClassFileTransformer;
 import java.lang.instrument.Instrumentation;
 import javax.annotation.Nullable;
@@ -49,15 +52,38 @@ public void run() {
 
   private static void disableBytecodeInstrumentation() {
     Instrumentation instrumentation = InstrumentationHolder.getInstrumentation();
-    ClassFileTransformer transformer = ClassFileTransformerHolder.getClassFileTransformer();
-    if (instrumentation == null || transformer == null) {
+    LambdaTransformer transformer = LambdaTransformerHolder.getLambdaTransformer();
+    ClassFileTransformer classFileTransformer = getDelegate(transformer);
+    if (instrumentation == null || classFileTransformer == null) {
       return;
     }
-    if (instrumentation.removeTransformer(transformer)) {
-      ClassFileTransformerHolder.setClassFileTransformer(null);
+    if (instrumentation.removeTransformer(classFileTransformer)) {
+      LambdaTransformerHolder.setLambdaTransformer(null);
     }
   }
 
+  @Nullable
+  private static ClassFileTransformer getDelegate(LambdaTransformer transformer) {
+    if (transformer instanceof Java8LambdaTransformer) {
+      try {
+        return (ClassFileTransformer)
+            Java8LambdaTransformer.class.getDeclaredField("delegate").get(transformer);
+      } catch (ReflectiveOperationException e) {
+        throw new IllegalStateException(e);
+      }
+    }
+    if (transformer instanceof Java9LambdaTransformer) {
+      try {
+        return (ClassFileTransformer)
+            Java9LambdaTransformer.class.getDeclaredField("delegate").get(transformer);
+      } catch (ReflectiveOperationException e) {
+        throw new IllegalStateException(e);
+      }
+    }
+    throw new IllegalStateException(
+        "Unexpected LambdaTransformer implementation: " + transformer.getClass());
+  }
+
   private void initialize() {
     RuntimeConfiguration runtimeConfig = runtimeConfigurator.getCurrentConfigCopy();
 
diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -61,6 +61,7 @@ include(":smoke-tests:framework")
 hideFromDependabot(":smoke-tests:apps:ActuatorMetrics")
 hideFromDependabot(":smoke-tests:apps:AutoPerfCounters")
 hideFromDependabot(":smoke-tests:apps:AzureSdk")
+hideFromDependabot(":smoke-tests:apps:AzureFunctions")
 hideFromDependabot(":smoke-tests:apps:BrowserSdkLoader")
 hideFromDependabot(":smoke-tests:apps:Cassandra")
 hideFromDependabot(":smoke-tests:apps:ClassicSdkLog4j1Interop2x")
diff --git a/smoke-tests/apps/AzureFunctions/build.gradle.kts b/smoke-tests/apps/AzureFunctions/build.gradle.kts
@@ -0,0 +1,7 @@
+plugins {
+  id("ai.smoke-test-jar")
+}
+
+dependencies {
+  implementation("org.springframework.boot:spring-boot-starter-web:2.5.12")
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/SpringBootApp.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/SpringBootApp.java
@@ -0,0 +1,42 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.applicationinsights.smoketestapp;
+
+import com.microsoft.azure.functions.worker.handler.FunctionEnvironmentReloadRequestHandler;
+import java.lang.reflect.Field;
+import java.util.Map;
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
+
+@SpringBootApplication
+public class SpringBootApp {
+
+  private static final String FAKE_BREEZE_INGESTION_ENDPOINT =
+      "http://host.testcontainers.internal:6060/";
+
+  public static void main(String[] args) throws Exception {
+
+    setEnv("AzureWebJobsStorage", "dummy");
+    setEnv(
+        "APPLICATIONINSIGHTS_CONNECTION_STRING",
+        "InstrumentationKey=00000000-0000-0000-0000-0FEEDDADBEEF;IngestionEndpoint="
+            + FAKE_BREEZE_INGESTION_ENDPOINT
+            + ";LiveEndpoint="
+            + FAKE_BREEZE_INGESTION_ENDPOINT);
+
+    new FunctionEnvironmentReloadRequestHandler().execute();
+
+    SpringApplication.run(SpringBootApp.class, args);
+  }
+
+  public static void setEnv(String name, String value) throws Exception {
+    Map<String, String> env = System.getenv();
+    Class<?> cl = env.getClass();
+    Field field = cl.getDeclaredField("m");
+    field.setAccessible(true);
+    @SuppressWarnings("unchecked")
+    Map<String, String> writableEnv = (Map<String, String>) field.get(env);
+    writableEnv.put(name, value);
+  }
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java
@@ -0,0 +1,21 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.applicationinsights.smoketestapp;
+
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RestController;
+
+@RestController
+public class TestController {
+
+  @GetMapping("/")
+  public String root() {
+    return "OK";
+  }
+
+  @GetMapping("/test")
+  public String test() {
+    return "OK!";
+  }
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/rpc/messages/InvocationRequest.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/rpc/messages/InvocationRequest.java
@@ -0,0 +1,15 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.azure.functions.rpc.messages;
+
+public class InvocationRequest {
+
+  public RpcTraceContext getTraceContext() {
+    throw new UnsupportedOperationException();
+  }
+
+  public String getInvocationId() {
+    throw new UnsupportedOperationException();
+  }
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/rpc/messages/RpcTraceContext.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/rpc/messages/RpcTraceContext.java
@@ -0,0 +1,21 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.azure.functions.rpc.messages;
+
+import java.util.Map;
+
+public class RpcTraceContext {
+
+  public Map<String, String> getAttributesMap() {
+    throw new UnsupportedOperationException();
+  }
+
+  public String getTraceParent() {
+    throw new UnsupportedOperationException();
+  }
+
+  public String getTraceState() {
+    throw new UnsupportedOperationException();
+  }
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/worker/handler/FunctionEnvironmentReloadRequestHandler.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/worker/handler/FunctionEnvironmentReloadRequestHandler.java
@@ -0,0 +1,10 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.azure.functions.worker.handler;
+
+public class FunctionEnvironmentReloadRequestHandler {
+
+  // calling this stub will trigger the azure functions initialization instrumentation
+  public void execute() {}
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/worker/handler/InvocationRequestHandler.java b/smoke-tests/apps/AzureFunctions/src/main/java/com/microsoft/azure/functions/worker/handler/InvocationRequestHandler.java
@@ -0,0 +1,11 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.azure.functions.worker.handler;
+
+import com.microsoft.azure.functions.rpc.messages.InvocationRequest;
+
+public class InvocationRequestHandler {
+
+  public void execute(InvocationRequest request) {}
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/ConsumptionPlanDisabledTest.java b/smoke-tests/apps/AzureFunctions/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/ConsumptionPlanDisabledTest.java
@@ -0,0 +1,62 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.applicationinsights.smoketest;
+
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_11;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_11_OPENJ9;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_17;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_17_OPENJ9;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_21;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_21_OPENJ9;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_8;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_8_OPENJ9;
+import static java.util.concurrent.TimeUnit.SECONDS;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+@UseAgent
+abstract class ConsumptionPlanDisabledTest {
+
+  @RegisterExtension
+  static final SmokeTestExtension testing =
+      SmokeTestExtension.builder()
+          .doNotSetConnectionString()
+          .setEnvVar("FUNCTIONS_WORKER_RUNTIME", "java")
+          .setEnvVar("APPLICATIONINSIGHTS_ENABLE_AGENT", "false")
+          .setSkipHealthCheck(true)
+          .build();
+
+  @Test
+  @TargetUri("/test")
+  void doMostBasicTest() throws InterruptedException {
+    SECONDS.sleep(10);
+    assertThat(testing.mockedIngestion.getItemCount()).isZero();
+  }
+
+  @Environment(JAVA_8)
+  static class Java8Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_8_OPENJ9)
+  static class Java8OpenJ9Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_11)
+  static class Java11Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_11_OPENJ9)
+  static class Java11OpenJ9Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_17)
+  static class Java17Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_17_OPENJ9)
+  static class Java17OpenJ9Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_21)
+  static class Java21Test extends ConsumptionPlanDisabledTest {}
+
+  @Environment(JAVA_21_OPENJ9)
+  static class Java21OpenJ9Test extends ConsumptionPlanDisabledTest {}
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/ConsumptionPlanEnabledTest.java b/smoke-tests/apps/AzureFunctions/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/ConsumptionPlanEnabledTest.java
@@ -0,0 +1,70 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+package com.microsoft.applicationinsights.smoketest;
+
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_11;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_11_OPENJ9;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_17;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_17_OPENJ9;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_21;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_21_OPENJ9;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_8;
+import static com.microsoft.applicationinsights.smoketest.EnvironmentValue.JAVA_8_OPENJ9;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.data.MapEntry.entry;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+@UseAgent
+abstract class ConsumptionPlanEnabledTest {
+
+  @RegisterExtension
+  static final SmokeTestExtension testing =
+      SmokeTestExtension.builder()
+          .doNotSetConnectionString()
+          .setEnvVar("FUNCTIONS_WORKER_RUNTIME", "java")
+          .setEnvVar("APPLICATIONINSIGHTS_ENABLE_AGENT", "true")
+          .setSkipHealthCheck(true) // to be consistent with the disabled test
+          .build();
+
+  @Test
+  @TargetUri("/test")
+  void doMostBasicTest() throws Exception {
+    Telemetry telemetry = testing.getTelemetry(0);
+
+    assertThat(telemetry.rd.getName()).isEqualTo("GET /test");
+    assertThat(telemetry.rd.getUrl()).matches("http://localhost:[0-9]+/test");
+    assertThat(telemetry.rd.getResponseCode()).isEqualTo("200");
+    assertThat(telemetry.rd.getSuccess()).isTrue();
+    assertThat(telemetry.rd.getSource()).isNull();
+    assertThat(telemetry.rd.getProperties())
+        .containsExactly(entry("_MS.ProcessedByMetricExtractors", "True"));
+    assertThat(telemetry.rd.getMeasurements()).isEmpty();
+  }
+
+  @Environment(JAVA_8)
+  static class Java8Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_8_OPENJ9)
+  static class Java8OpenJ9Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_11)
+  static class Java11Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_11_OPENJ9)
+  static class Java11OpenJ9Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_17)
+  static class Java17Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_17_OPENJ9)
+  static class Java17OpenJ9Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_21)
+  static class Java21Test extends ConsumptionPlanEnabledTest {}
+
+  @Environment(JAVA_21_OPENJ9)
+  static class Java21OpenJ9Test extends ConsumptionPlanEnabledTest {}
+}
diff --git a/smoke-tests/apps/AzureFunctions/src/smokeTest/resources/logback-test.xml b/smoke-tests/apps/AzureFunctions/src/smokeTest/resources/logback-test.xml
@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<configuration>
+  <appender name="CONSOLE" class="ch.qos.logback.core.ConsoleAppender">
+    <encoder>
+      <pattern>%d{yyyy-MM-dd HH:mm:ss.SSS} %-5level %logger{36} - %msg%n</pattern>
+    </encoder>
+  </appender>
+  <root level="warn">
+    <appender-ref ref="CONSOLE"/>
+  </root>
+</configuration>
diff --git a/smoke-tests/apps/OpenTelemetryApiLogBridge/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java b/smoke-tests/apps/OpenTelemetryApiLogBridge/src/main/java/com/microsoft/applicationinsights/smoketestapp/TestController.java
@@ -31,7 +31,7 @@ public String testCustomExceptionTypeAndMessage() {
         .setSeverity(Severity.INFO)
         .setAttribute(ExceptionAttributes.EXCEPTION_TYPE, "my exception type")
         .setAttribute(
-                ExceptionAttributes.EXCEPTION_MESSAGE,
+            ExceptionAttributes.EXCEPTION_MESSAGE,
             "This is an custom exception with custom exception type")
         .setAttribute(ExceptionAttributes.EXCEPTION_STACKTRACE, sw.toString())
         .emit();
diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtension.java
@@ -104,6 +104,7 @@ public class SmokeTestExtension
   private final File javaagentFile;
   private final File agentExtensionFile;
   private final Map<String, String> httpHeaders;
+  private final Map<String, String> envVars;
   private final boolean useDefaultHttpPort;
   private final boolean useOtlpEndpoint;
 
@@ -128,6 +129,7 @@ public static SmokeTestExtensionBuilder builder() {
       File agentExtensionFile,
       ProfilerState profilerState,
       Map<String, String> httpHeaders,
+      Map<String, String> envVars,
       boolean useDefaultHttpPort,
       boolean useOtlpEndpoint) {
     this.skipHealthCheck = skipHealthCheck;
@@ -155,6 +157,7 @@ public static SmokeTestExtensionBuilder builder() {
     javaagentFile = new File(System.getProperty(javaagentPathSystemProperty));
 
     this.httpHeaders = httpHeaders;
+    this.envVars = envVars;
     this.useDefaultHttpPort = useDefaultHttpPort;
     this.useOtlpEndpoint = useOtlpEndpoint;
   }
@@ -421,6 +424,7 @@ private void startTestApplicationContainer() throws Exception {
             .withEnv("APPLICATIONINSIGHTS_SELF_DIAGNOSTICS_LEVEL", selfDiagnosticsLevel)
             .withEnv("OTEL_RESOURCE_ATTRIBUTES", otelResourceAttributesEnvVar)
             .withEnv("APPLICATIONINSIGHTS_METRIC_INTERVAL_SECONDS", "1")
+            .withEnv(envVars)
             .withNetwork(network)
             .withFileSystemBind(
                 appFile.getAbsolutePath(),
diff --git a/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtensionBuilder.java b/smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/SmokeTestExtensionBuilder.java
