remove JDK 21 check because it'll always be true from now on

Author: xiang17

buildSrc/src/main/kotlin/ai.java-conventions.gradle.kts

@@ -32,12 +32,10 @@ tasks.withType<JavaCompile>().configureEach {
   with(options) {
     release.set(8)
     compilerArgs.add("-Werror")
-    // We need to support compiling to Java 8 even when using JDK 21 to build.
+    // We need to support compiling to Java 8.
     // Suppress obsolete source/target warning added in JDK 21 while retaining -Werror for everything else.
     // This only disables the 'options' lint category (e.g., the obsolete source/target messages).
-    if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_21)) {
-      compilerArgs.add("-Xlint:-options")
-    }
+    compilerArgs.add("-Xlint:-options")
   }
 }
 

buildSrc/src/main/kotlin/ai.smoke-test.gradle.kts

@@ -38,12 +38,10 @@ tasks.withType<JavaCompile>().configureEach {
   with(options) {
     release.set(8)
     compilerArgs.add("-Werror")
-    // We need to support compiling to Java 8 even when using JDK 21 to build.
+    // We need to support compiling to Java 8.
     // Suppress obsolete source/target warning added in JDK 21 while retaining -Werror for everything else.
     // This only disables the 'options' lint category (e.g., the obsolete source/target messages).
-    if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_21)) {
-      compilerArgs.add("-Xlint:-options")
-    }
+    compilerArgs.add("-Xlint:-options")
   }
 }
 

smoke-tests/apps/DiagnosticExtension/MockExtension/build.gradle.kts

@@ -18,12 +18,10 @@ tasks.withType<JavaCompile>().configureEach {
   with(options) {
     release.set(8)
     compilerArgs.add("-Werror")
-    // We need to support compiling to Java 8 even when using JDK 21 to build.
+    // We need to support compiling to Java 8.
     // Suppress obsolete source/target warning added in JDK 21 while retaining -Werror for everything else.
     // This only disables the 'options' lint category (e.g., the obsolete source/target messages).
-    if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_21)) {
-      compilerArgs.add("-Xlint:-options")
-    }
+    compilerArgs.add("-Xlint:-options")
   }
 }