Create enum StatusCode (#2346)

* Create enum StatusCode

* Update StatusCode

* Apply spotless

Author: jeanbisutti

agent/agent-bootstrap/src/main/java/com/microsoft/applicationinsights/agent/bootstrap/diagnostics/DiagnosticsHelper.java

@@ -70,6 +70,7 @@ public static void setAgentJarFile(Path agentPath) {
     }
   }
 
+  /** Is resource provider (Azure Spring Cloud, AppService, Azure Functions, AKS, VM...). */
   public static boolean isRpIntegration() {
     return rpIntegrationChar != 0;
   }

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/statsbeat/NetworkStatsbeatHttpPipelinePolicy.java

@@ -25,7 +25,7 @@
 import com.azure.core.http.HttpPipelineNextPolicy;
 import com.azure.core.http.HttpResponse;
 import com.azure.core.http.policy.HttpPipelinePolicy;
-import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCodes;
+import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCode;
 import com.microsoft.applicationinsights.agent.internal.utils.Constant;
 import java.util.concurrent.atomic.AtomicLong;
 import reactor.core.publisher.Mono;
@@ -56,12 +56,12 @@ public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineN
               if (statusCode == 200) {
                 networkStatsbeat.incrementRequestSuccessCount(
                     System.currentTimeMillis() - startTime.get(), instrumentationKey, host);
-              } else if (StatusCodes.isRedirect(statusCode)) {
+              } else if (StatusCode.isRedirect(statusCode)) {
                 // these are not tracked as success or failure since they are just redirects
               } else if (statusCode == 402 || statusCode == 439) {
                 networkStatsbeat.incrementThrottlingCount(
                     instrumentationKey, host, Constant.STATUS_CODE, statusCode);
-              } else if (StatusCodes.isRetryable(statusCode)) {
+              } else if (StatusCode.isRetryable(statusCode)) {
                 networkStatsbeat.incrementRetryCount(
                     instrumentationKey, host, Constant.STATUS_CODE, statusCode);
               } else {

agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/localstorage/LocalFileSenderTelemetryPipelineListener.java

@@ -24,7 +24,7 @@
 import com.azure.monitor.opentelemetry.exporter.implementation.pipeline.TelemetryPipelineListener;
 import com.azure.monitor.opentelemetry.exporter.implementation.pipeline.TelemetryPipelineRequest;
 import com.azure.monitor.opentelemetry.exporter.implementation.pipeline.TelemetryPipelineResponse;
-import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCodes;
+import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCode;
 import io.opentelemetry.sdk.common.CompletableResultCode;
 import java.io.File;
 
@@ -44,7 +44,7 @@ public void onResponse(TelemetryPipelineRequest request, TelemetryPipelineRespon
     if (responseCode == 200) {
       localFileLoader.updateProcessedFileStatus(true, file);
     } else {
-      localFileLoader.updateProcessedFileStatus(!StatusCodes.isRetryable(responseCode), file);
+      localFileLoader.updateProcessedFileStatus(!StatusCode.isRetryable(responseCode), file);
     }
   }
 

agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/localstorage/LocalStorageTelemetryPipelineListener.java

@@ -25,7 +25,7 @@
 import com.azure.monitor.opentelemetry.exporter.implementation.pipeline.TelemetryPipelineListener;
 import com.azure.monitor.opentelemetry.exporter.implementation.pipeline.TelemetryPipelineRequest;
 import com.azure.monitor.opentelemetry.exporter.implementation.pipeline.TelemetryPipelineResponse;
-import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCodes;
+import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCode;
 import io.opentelemetry.sdk.common.CompletableResultCode;
 import java.io.File;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -62,7 +62,7 @@ public LocalStorageTelemetryPipelineListener(
 
   @Override
   public void onResponse(TelemetryPipelineRequest request, TelemetryPipelineResponse response) {
-    if (StatusCodes.isRetryable(response.getStatusCode())) {
+    if (StatusCode.isRetryable(response.getStatusCode())) {
       localFileWriter.writeToDisk(request.getInstrumentationKey(), request.getTelemetry());
     }
   }

agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/pipeline/TelemetryPipeline.java

@@ -25,7 +25,7 @@
 import com.azure.core.http.HttpResponse;
 import com.azure.core.util.Context;
 import com.azure.core.util.tracing.Tracer;
-import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCodes;
+import com.azure.monitor.opentelemetry.exporter.implementation.utils.StatusCode;
 import io.opentelemetry.sdk.common.CompletableResultCode;
 import java.net.MalformedURLException;
 import java.net.URL;
@@ -132,7 +132,7 @@ private void onResponseBody(
 
     int responseCode = response.getStatusCode();
 
-    if (StatusCodes.isRedirect(responseCode) && remainingRedirects > 0) {
+    if (StatusCode.isRedirect(responseCode) && remainingRedirects > 0) {
       String location = response.getHeaderValue("Location");
       URL locationUrl;
       try {

agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/StatusCodes.java renamed to agent/azure-monitor-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/utils/StatusCode.java

@@ -21,20 +21,32 @@
 
 package com.azure.monitor.opentelemetry.exporter.implementation.utils;
 
-public class StatusCodes {
+public enum StatusCode {
+  UNAUTHORIZED(401),
+  FORBIDDEN(403),
+  REQUEST_TIMEOUT(408),
+  TOO_MANY_REQUESTS(429),
+  INTERNAL_SERVER_ERROR(500),
+  SERVICE_UNAVAILABLE(503),
+  TEMPORARY_REDIRECT(307),
+  PERMANENTY_REDIRECT(308);
+
+  private final int code;
+
+  StatusCode(int code) {
+    this.code = code;
+  }
 
   public static boolean isRetryable(int statusCode) {
-    return statusCode == 401 // Unauthorized
-        || statusCode == 403 // Forbidden
-        || statusCode == 408 // REQUEST TIMEOUT
-        || statusCode == 429 // TOO MANY REQUESTS
-        || statusCode == 500 // INTERNAL SERVER ERROR
-        || statusCode == 503; // SERVICE UNAVAILABLE
+    return statusCode == UNAUTHORIZED.code
+        || statusCode == FORBIDDEN.code
+        || statusCode == REQUEST_TIMEOUT.code
+        || statusCode == TOO_MANY_REQUESTS.code
+        || statusCode == INTERNAL_SERVER_ERROR.code
+        || statusCode == SERVICE_UNAVAILABLE.code;
   }
 
   public static boolean isRedirect(int statusCode) {
     return statusCode == 307 || statusCode == 308;
   }
-
-  private StatusCodes() {}
 }