Skip to content

Commit 879c66b

Browse files
Copilottrask
andcommitted
Remove redundant defensive check for exception class names
Co-authored-by: trask <[email protected]>
1 parent 03b720e commit 879c66b

File tree

2 files changed

+1
-12
lines changed
  • agent/agent-tooling/src

2 files changed

+1
-12
lines changed

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryUtil.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -61,12 +61,6 @@ private static ExceptionDetailBuilder createWithStackInfo(
6161
if (Strings.isNullOrEmpty(exceptionMessage)) {
6262
exceptionMessage = exception.getClass().getName();
6363
}
64-
65-
// Defensive check to ensure the message is never null or empty
66-
if (Strings.isNullOrEmpty(exceptionMessage)) {
67-
exceptionMessage = "Unknown Exception";
68-
}
69-
7064
exceptionDetails.setMessage(exceptionMessage);
7165

7266
if (parentExceptionDetails != null) {

agent/agent-tooling/src/test/java/com/microsoft/applicationinsights/agent/internal/classicsdk/TelemetryUtilTest.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,17 +57,12 @@ public void testExceptionMessageHandling() {
5757
String testMessage = testMessages[i];
5858
String expectedResult = expectedResults[i];
5959

60-
// Simulate TelemetryUtil logic with defensive check
60+
// Simulate TelemetryUtil logic
6161
String exceptionMessage = testMessage;
6262
if (Strings.isNullOrEmpty(exceptionMessage)) {
6363
exceptionMessage = "java.lang.NullPointerException";
6464
}
6565

66-
// Defensive check to ensure the message is never null or empty
67-
if (Strings.isNullOrEmpty(exceptionMessage)) {
68-
exceptionMessage = "Unknown Exception";
69-
}
70-
7166
assertThat(exceptionMessage).isEqualTo(expectedResult);
7267
}
7368
}

0 commit comments

Comments
 (0)