Don't log Log Records if they are sampled out (#3936)

trask · web-flow · commit 88b28f6767a0 · 2024-11-13T07:12:02.000-08:00
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentLogExporter.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentLogExporter.java
@@ -96,7 +96,6 @@ private CompletableResultCode internalExport(Collection<LogRecordData> logs) {
       return CompletableResultCode.ofFailure();
     }
     for (LogRecordData log : logs) {
-      logger.debug("exporting log: {}", log);
       try {
         int severityNumber = log.getSeverity().getSeverityNumber();
         if (severityNumber < severityThreshold) {
@@ -124,6 +123,8 @@ private CompletableResultCode internalExport(Collection<LogRecordData> logs) {
           continue;
         }
 
+        logger.debug("exporting log: {}", log);
+
         TelemetryItem telemetryItem = mapper.map(log, stack, samplingPercentage);
         telemetryItemConsumer.accept(telemetryItem);
 

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,6 @@ private CompletableResultCode internalExport(Collection<LogRecordData> logs) {`
`96`	`96`	`return CompletableResultCode.ofFailure();`
`97`	`97`	`}`
`98`	`98`	`for (LogRecordData log : logs) {`
`99`		`- logger.debug("exporting log: {}", log);`
`100`	`99`	`try {`
`101`	`100`	`int severityNumber = log.getSeverity().getSeverityNumber();`
`102`	`101`	`if (severityNumber < severityThreshold) {`
`@@ -124,6 +123,8 @@ private CompletableResultCode internalExport(Collection<LogRecordData> logs) {`
`124`	`123`	`continue;`
`125`	`124`	`}`
`126`	`125`
	`126`	`+ logger.debug("exporting log: {}", log);`
	`127`	`+`
`127`	`128`	`TelemetryItem telemetryItem = mapper.map(log, stack, samplingPercentage);`
`128`	`129`	`telemetryItemConsumer.accept(telemetryItem);`
`129`	`130`