Fix a TODO (#1992)

Author: trask

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/processors/AttributeProcessor.java

@@ -55,19 +55,6 @@ public static AttributeProcessor create(ProcessorConfig config) {
     return new AttributeProcessor(config.actions, normalizedInclude, normalizedExclude);
   }
 
-  // this won't be needed once we update to 0.13.0
-  // see https://github.com/open-telemetry/opentelemetry-java/pull/2284
-  @Nullable
-  public static String getAttribute(Attributes attributes, AttributeKey<String> key) {
-    Object existingValueObj = attributes.get(key);
-    // checking the return type won't be needed once we update to 0.13.0
-    // see https://github.com/open-telemetry/opentelemetry-java/pull/2284
-    if (existingValueObj instanceof String) {
-      return (String) existingValueObj;
-    }
-    return null;
-  }
-
   // Function to process actions
   public SpanData processActions(SpanData span) {
     SpanData updatedSpan = span;
@@ -103,7 +90,7 @@ private static SpanData processInsertAction(SpanData span, ProcessorAction actio
       builder.putAll(existingSpanAttributes);
       return new MySpanData(span, builder.build());
     }
-    String fromAttributeValue = getAttribute(existingSpanAttributes, actionObj.fromAttribute);
+    String fromAttributeValue = existingSpanAttributes.get(actionObj.fromAttribute);
     if (fromAttributeValue != null) {
       AttributesBuilder builder = Attributes.builder();
       builder.put(actionObj.key, fromAttributeValue);
@@ -115,7 +102,7 @@ private static SpanData processInsertAction(SpanData span, ProcessorAction actio
 
   private static SpanData processUpdateAction(SpanData span, ProcessorAction actionObj) {
     // Currently we only support String
-    String existingValue = getAttribute(span.getAttributes(), actionObj.key);
+    String existingValue = span.getAttributes().get(actionObj.key);
     if (existingValue == null) {
       return span;
     }
@@ -126,7 +113,7 @@ private static SpanData processUpdateAction(SpanData span, ProcessorAction actio
       builder.put(actionObj.key, actionObj.value);
       return new MySpanData(span, builder.build());
     }
-    String fromAttributeValue = getAttribute(span.getAttributes(), actionObj.fromAttribute);
+    String fromAttributeValue = span.getAttributes().get(actionObj.fromAttribute);
     if (fromAttributeValue != null) {
       AttributesBuilder builder = span.getAttributes().toBuilder();
       builder.put(actionObj.key, fromAttributeValue);
@@ -137,7 +124,7 @@ private static SpanData processUpdateAction(SpanData span, ProcessorAction actio
 
   private static SpanData processDeleteAction(SpanData span, ProcessorAction actionObj) {
     // Currently we only support String
-    String existingValue = getAttribute(span.getAttributes(), actionObj.key);
+    String existingValue = span.getAttributes().get(actionObj.key);
     if (existingValue == null) {
       return span;
     }
@@ -154,7 +141,7 @@ private static SpanData processDeleteAction(SpanData span, ProcessorAction actio
 
   private static SpanData procesHashAction(SpanData span, ProcessorAction actionObj) {
     // Currently we only support String
-    String existingValue = getAttribute(span.getAttributes(), actionObj.key);
+    String existingValue = span.getAttributes().get(actionObj.key);
     if (existingValue == null) {
       return span;
     }
@@ -165,7 +152,7 @@ private static SpanData procesHashAction(SpanData span, ProcessorAction actionOb
 
   private static SpanData processExtractAction(SpanData span, ProcessorAction actionObj) {
     // Currently we only support String
-    String existingValue = getAttribute(span.getAttributes(), actionObj.key);
+    String existingValue = span.getAttributes().get(actionObj.key);
     if (existingValue == null) {
       return span;
     }