initial test changes

Author: harsimar

smoke-tests/apps/LiveMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/LiveMetricsTest.java

@@ -22,9 +22,11 @@
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.List;
-import com.azure.json.JsonToken;
 import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.DocumentIngress;
-import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.DocumentStreamInfo;
+import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.Exception;
+import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.Trace;
+import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.DocumentType;
+import com.azure.monitor.opentelemetry.autoconfigure.implementation.quickpulse.swagger.models.MetricPoint;
 import org.awaitility.Awaitility;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
@@ -39,28 +41,68 @@ abstract class LiveMetricsTest {
 
   @Test
   @TargetUri("/test")
-  void testPingPostAndTelemetryDataFlow() throws Exception {
-
+  void testTelemetryDataFlow() throws java.lang.Exception {
     Awaitility.await()
-        .atMost(Duration.ofSeconds(15));
-
-    assertThat(testing.mockedIngestion.getNumPingsReceived()).isEqualTo(1);
-    //ping body
-    String pingBody = testing.mockedIngestion.getLastPingBody();
-
-    // After the ping, we expect a post to happen roughly every second.
-    assertThat(testing.mockedIngestion.getNumPostsReceived()).isGreaterThanOrEqualTo(10);
-    String postBody = testing.mockedIngestion.getLastPostBody();
-
-    // Verify that the telemetry data is in the last post body
-    JsonReader reader = JsonProviders.createReader(postBody);
-    List<MonitoringDataPoint> dataPoints = reader.readArray(MonitoringDataPoint::fromJson);
-    assertThat(dataPoints).hasSize(1);
-
-    MonitoringDataPoint dataPoint = dataPoints.get(0);
-    List<DocumentIngress> docs = dataPoint.getDocuments();
-
-
+        .atMost(Duration.ofSeconds(20));
+
+
+    assertThat(testing.mockedIngestion.isPingReceived()).isTrue();
+
+
+    List<String> postBodies = testing.mockedIngestion.getPostBodies();
+    assertThat(postBodies).hasSizeGreaterThan(0); // should post at least once
+
+    boolean foundExceptionDoc = false;
+    boolean foundTraceDoc = false;
+    boolean foundDependency = false;
+    boolean foundRequest = false;
+
+    for (String postBody : postBodies) {
+      // Verify that the telemetry data is in the last post body
+      List<MonitoringDataPoint> dataPoints = new ArrayList<>();
+      try {
+        JsonReader reader = JsonProviders.createReader(postBody);
+        dataPoints = reader.readArray(MonitoringDataPoint::fromJson);
+      } catch (IOException e) {
+        throw new java.lang.Exception("Failed to parse post request body", e);
+      }
+
+      assertThat(dataPoints).hasSize(1);
+      MonitoringDataPoint dataPoint = dataPoints.get(0);
+      List<DocumentIngress> docs = dataPoint.getDocuments();
+      List<MetricPoint> metrics = dataPoint.getMetrics();
+      // check that the expected documents are present
+      // With the default filtering configuration, we should only see the exception and trace documents.
+      // Request/Dep did not fail, so there should not be documents for those.
+
+      for (DocumentIngress doc : docs) {
+        if (doc.getDocumentType().equals(DocumentType.EXCEPTION) &&
+            ((Exception) doc).getExceptionMessage().equals("Fake Exception")) {
+          foundExceptionDoc = true;
+        } else if (doc.getDocumentType().equals(DocumentType.TRACE) &&
+            ((Trace) doc).getMessage().equals("This message should generate a trace")) {
+          foundTraceDoc = true;
+        }
+      }
+
+      // check that the expected metrics have the correct values
+
+      for (MetricPoint metric : metrics) {
+        String name = metric.getName();
+        double value = metric.getValue();
+        if (name.equals("\\ApplicationInsights\\Dependency Calls/Sec") && value == 1) {
+          foundDependency = true;
+        } else if (name.equals("\\ApplicationInsights\\Requests/Sec") && value == 1) {
+          foundRequest = true;
+        }
+      }
+
+    }
+
+    assertThat(foundExceptionDoc).isTrue();
+    assertThat(foundTraceDoc).isTrue();
+    assertThat(foundDependency).isTrue();
+    assertThat(foundRequest).isTrue();
 
   }
 

smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedAppInsightsIngestionServer.java

@@ -279,20 +279,12 @@ public boolean test(Envelope input) {
     return items;
   }
 
-  public int getNumPingsReceived() {
-    return quickPulseServlet.getNumPingsReceived();
+  public boolean isPingReceived() {
+    return quickPulseServlet.isPingReceived();
   }
 
-  public int getNumPostsReceived() {
-    return quickPulseServlet.getNumPostsReceived();
-  }
-
-  public String getLastPingBody() {
-    return quickPulseServlet.getPingBody();
-  }
-
-  public String getLastPostBody() {
-    return quickPulseServlet.getLastPostBody();
+  public List<String> getPostBodies() {
+    return quickPulseServlet.getPostBodies();
   }
 
   @SuppressWarnings("SystemOut")

smoke-tests/framework/src/main/java/com/microsoft/applicationinsights/smoketest/fakeingestion/MockedQuickPulseServlet.java

@@ -8,17 +8,15 @@
 import javax.servlet.http.HttpServletResponse;
 import java.io.IOException;
 import java.io.StringWriter;
-import java.util.concurrent.atomic.AtomicInteger;
-import java.util.concurrent.atomic.AtomicReference;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicBoolean;
 
 public class MockedQuickPulseServlet extends HttpServlet {
 
-  private final AtomicInteger liveMetricsPingReceived = new AtomicInteger();
-
-  private final AtomicInteger liveMetricsPostReceived = new AtomicInteger();
-
-  private final AtomicReference<String> pingBody = new AtomicReference<>();
-  private final AtomicReference<String> lastPostBody = new AtomicReference<>();
+  private final AtomicBoolean pingReceived = new AtomicBoolean(false);
+  private final List<String> postBodies = new ArrayList<>();
+  private final Object lock = new Object();
 
   private static final String MOCK_RESPONSE_JSON_DEFAULT_CONFIG =
       "{\"ETag\":\"fake::etag\",\"Metrics\":[],\"QuotaInfo\":null,\"DocumentStreams\":[{\"Id\":\"all-types-default\",\"DocumentFilterGroups\":[{\"TelemetryType\":\"Request\",\"Filters\":{\"Filters\":[{\"FieldName\":\"Success\",\"Predicate\":\"Equal\",\"Comparand\":\"false\"}]}},{\"TelemetryType\":\"Dependency\",\"Filters\":{\"Filters\":[{\"FieldName\":\"Success\",\"Predicate\":\"Equal\",\"Comparand\":\"false\"}]}},{\"TelemetryType\":\"Exception\",\"Filters\":{\"Filters\":[]}},{\"TelemetryType\":\"Event\",\"Filters\":{\"Filters\":[]}},{\"TelemetryType\":\"Trace\",\"Filters\":{\"Filters\":[]}}]}]}";
@@ -46,39 +44,35 @@ protected void doPost(HttpServletRequest req, HttpServletResponse resp)
       String path = req.getPathInfo();
       logit("QuickPulse received: " + path);
       if (path.equals("/ping")) {
-          liveMetricsPingReceived.incrementAndGet();
-          pingBody.set(body);
+          pingReceived.set(true);
           logit("ping body: " + body);
           // want the following request to be a post
+          resp.setHeader("x-ms-qps-configuration-etag", "fake::etag");
           resp.setHeader("x-ms-qps-subscribed", "true");
           resp.setContentType("application/json");
           resp.getWriter().write(MOCK_RESPONSE_JSON_DEFAULT_CONFIG);
 
       } else if (path.equals("/post")) {
-          liveMetricsPostReceived.incrementAndGet();
-          lastPostBody.set(body);
+          synchronized (lock) {
+              postBodies.add(body);
+          }
           logit("post body: " + body);
           // continue to post
           resp.setHeader("x-ms-qps-subscribed", "true");
+          resp.setHeader("x-ms-qps-configuration-etag", "fake::etag");
       } else {
           resp.setStatus(404);
       }
   }
 
-  public int getNumPingsReceived() {
-    return liveMetricsPingReceived.get();
-  }
-
-  public int getNumPostsReceived() {
-    return liveMetricsPostReceived.get();
+  public boolean isPingReceived() {
+    return pingReceived.get();
   }
 
-  public String getPingBody() {
-    return pingBody.get();
-  }
-
-  public String getLastPostBody() {
-    return lastPostBody.get();
+  public List<String> getPostBodies() {
+    synchronized (lock) {
+      return new ArrayList<>(postBodies);
+    }
   }
 
   public void setRequestLoggingEnabled(boolean enabled) {