Skip to content

Commit a9c8ca1

Browse files
Copilottrask
andcommitted
Refactor LiveMetrics test to use single Awaitility block for all assertions
Co-authored-by: trask <[email protected]>
1 parent 2f9980a commit a9c8ca1

File tree

1 file changed

+10
-2
lines changed
  • smoke-tests/apps/LiveMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest

1 file changed

+10
-2
lines changed

smoke-tests/apps/LiveMetrics/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/LiveMetricsTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,24 @@ void testTelemetryDataFlow() throws java.lang.Exception {
5050

5151
assertThat(testing.mockedIngestion.isPingReceived()).isTrue();
5252

53-
// Wait for dependency metric to be available in LiveMetrics post bodies
53+
// Wait for all telemetry to be available in LiveMetrics post bodies
5454
Awaitility.await()
5555
.atMost(Duration.ofSeconds(30))
5656
.until(() -> {
5757
List<String> postBodies = testing.mockedIngestion.getPostBodies();
58+
if (postBodies.isEmpty()) {
59+
return false;
60+
}
61+
5862
PostBodyVerifier tempVerifier = new PostBodyVerifier();
5963
for (String postBody : postBodies) {
6064
tempVerifier.searchPostBody(postBody);
6165
}
62-
return tempVerifier.hasDependency();
66+
67+
return tempVerifier.hasExceptionDoc()
68+
&& tempVerifier.hasTraceDoc()
69+
&& tempVerifier.hasDependency()
70+
&& tempVerifier.hasRequest();
6371
});
6472

6573
List<String> postBodies = testing.mockedIngestion.getPostBodies();

0 commit comments

Comments
 (0)