Skip to content

Commit ba26600

Browse files
committed
hide static inner class
1 parent a839f97 commit ba26600

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/AiSampler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ private static SamplingResult useLocalParentDecisionIfPossible(
107107
if (parentSpanSampleRate == null) {
108108
return null;
109109
}
110-
return new SamplerUtil.RecordAndSampleWithItemCount(parentSpanSampleRate);
110+
return SamplerUtil.createSamplingResultWithSampleRateAndItemCount(parentSpanSampleRate);
111111
}
112112

113113
@Override

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/AiSamplerForOverride.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ private SamplingResult useLocalParentDecisionIfPossible(
9999
return null;
100100
}
101101
// don't sample more dependencies than parent in this case
102-
return new SamplerUtil.RecordAndSampleWithItemCount(parentSpanSampleRate);
102+
return SamplerUtil.createSamplingResultWithSampleRateAndItemCount(parentSpanSampleRate);
103103
}
104104

105105
@Override

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/SamplerUtil.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ static SamplingResult shouldSample(String traceId, double sp) {
3636

3737
samplingResult = recordAndSampleWithSampleRateMap.get(sp);
3838
if (samplingResult == null) {
39-
samplingResult = new RecordAndSampleWithItemCount(sp);
39+
samplingResult = createSamplingResultWithSampleRateAndItemCount(sp);
4040
recordAndSampleWithSampleRateMap.put(sp, samplingResult);
4141
}
4242
return samplingResult;
@@ -54,7 +54,11 @@ public static boolean shouldRecordAndSample(String traceId, double percentage) {
5454
return SamplingScoreGeneratorV2.getSamplingScore(traceId) < percentage;
5555
}
5656

57-
static class RecordAndSampleWithItemCount implements SamplingResult {
57+
static SamplingResult createSamplingResultWithSampleRateAndItemCount(double sampleRate) {
58+
return new RecordAndSampleWithItemCount(sampleRate);
59+
}
60+
61+
private static class RecordAndSampleWithItemCount implements SamplingResult {
5862

5963
private final Attributes attributes;
6064

0 commit comments

Comments
 (0)