Skip to content

Commit c0c83f6

Browse files
committed
Rework some log messages
1 parent f3136a3 commit c0c83f6

File tree

3 files changed

+19
-17
lines changed

3 files changed

+19
-17
lines changed

core/src/main/java/com/microsoft/applicationinsights/internal/channel/samplingV2/FixedRateSamplingTelemetryProcessor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public boolean process(Telemetry telemetry) {
170170

171171
if (SamplingScoreGeneratorV2.getSamplingScore(telemetry) >= sp) {
172172

173-
InternalLogger.INSTANCE.info("Item %s sampled out", telemetry.getClass().getSimpleName());
173+
InternalLogger.INSTANCE.trace("Item %s sampled out", telemetry.getClass().getSimpleName());
174174
return false;
175175
}
176176

core/src/main/java/com/microsoft/applicationinsights/internal/heartbeat/HeartBeatModule.java

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -59,37 +59,38 @@ public HeartBeatModule(Map<String, String> properties) {
5959
try {
6060
setHeartBeatInterval(Long.parseLong(entry.getValue()));
6161
} catch (Exception e) {
62-
InternalLogger.INSTANCE.trace("Exception while adding Heartbeat interval,"
63-
+ " Stack trace is: %s", ExceptionUtils.getStackTrace(e));
62+
if (InternalLogger.INSTANCE.isTraceEnabled()) {
63+
InternalLogger.INSTANCE.trace("Exception while adding Heartbeat interval: %s", ExceptionUtils.getStackTrace(e));
64+
}
6465
}
6566
break;
6667
case "isHeartBeatEnabled":
6768
try {
6869
setHeartBeatEnabled(Boolean.parseBoolean(entry.getValue()));
69-
}
70-
catch (Exception e) {
71-
InternalLogger.INSTANCE.trace("Exception while adding enabling/disabling heartbeat,"
72-
+ " Stack trace is: %s", ExceptionUtils.getStackTrace(e));
70+
} catch (Exception e) {
71+
if (InternalLogger.INSTANCE.isTraceEnabled()) {
72+
InternalLogger.INSTANCE.trace("Exception while adding enabling/disabling heartbeat: %s", ExceptionUtils.getStackTrace(e));
73+
}
7374
}
7475
break;
7576
case "ExcludedHeartBeatPropertiesProvider":
7677
try {
7778
List<String> excludedHeartBeatPropertiesProviderList = parseStringToList(entry.getValue());
7879
setExcludedHeartBeatPropertiesProvider(excludedHeartBeatPropertiesProviderList);
79-
}
80-
catch (Exception e) {
81-
InternalLogger.INSTANCE.trace("Exception while adding Excluded Heartbeat providers,"
82-
+ " Stack trace is: %s", ExceptionUtils.getStackTrace(e));
80+
} catch (Exception e) {
81+
if (InternalLogger.INSTANCE.isTraceEnabled()) {
82+
InternalLogger.INSTANCE.trace("Exception while adding Excluded Heartbeat providers: %s", ExceptionUtils.getStackTrace(e));
83+
}
8384
}
8485
break;
8586
case "ExcludedHeartBeatProperties":
8687
try {
8788
List<String> excludedHeartBeatPropertiesList = parseStringToList(entry.getValue());
8889
setExcludedHeartBeatProperties(excludedHeartBeatPropertiesList);
89-
}
90-
catch (Exception e) {
91-
InternalLogger.INSTANCE.trace("Exception while adding excluded heartbeat properties,"
92-
+ " Stack trace is: %s", ExceptionUtils.getStackTrace(e));
90+
} catch (Exception e) {
91+
if (InternalLogger.INSTANCE.isTraceEnabled()) {
92+
InternalLogger.INSTANCE.trace("Exception while adding excluded heartbeat properties: %s", ExceptionUtils.getStackTrace(e));
93+
}
9394
}
9495
break;
9596
default:

web/src/main/java/com/microsoft/applicationinsights/web/internal/httputils/HttpServerHandler.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,9 @@ public void handleEnd(ServletRequest request, ServletResponse response,
140140
*/
141141
public void handleException(Exception e) {
142142
try {
143-
InternalLogger.INSTANCE.trace("Unhandled exception while processing request: %s",
144-
ExceptionUtils.getStackTrace(e));
143+
if (InternalLogger.INSTANCE.isTraceEnabled()) {
144+
InternalLogger.INSTANCE.trace("Unhandled exception while processing request: %s", ExceptionUtils.getStackTrace(e));
145+
}
145146
if (telemetryClient != null) {
146147
telemetryClient.trackException(e);
147148
}

0 commit comments

Comments
 (0)