Fix truncation log spamming (#2066)

* Fix truncation log spamming

* Fix CI

* Better logging for smoke test failures

Author: trask

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/common/TelemetryTruncation.java

@@ -37,12 +37,12 @@ public static String truncateTelemetry(String value, int maxLength, String attri
     if (value == null || value.length() <= maxLength) {
       return value;
     }
-    if (!alreadyLoggedAttributeNames.add(attributeName)) {
+    if (alreadyLoggedAttributeNames.add(attributeName)) {
       // this can be expected, so don't want to flood the logs with a lot of these
       // (and don't want to log the full value, e.g. sql text > 8192 characters)
       logger.warn(
           "truncated {} attribute value to {} characters (this message will only be logged once"
-              + " per attribute name, and only for at most 10 different attribute names): {}",
+              + " per attribute name): {}",
           attributeName,
           maxLength,
           trimTo80(value));
@@ -56,7 +56,7 @@ public static String truncatePropertyValue(String value, int maxLength, String p
     if (value == null || value.length() <= maxLength) {
       return value;
     }
-    if (alreadyLoggedPropertyKeys.size() < 10 && !alreadyLoggedPropertyKeys.add(propertyKey)) {
+    if (alreadyLoggedPropertyKeys.size() < 10 && alreadyLoggedPropertyKeys.add(propertyKey)) {
       // this can be expected, so don't want to flood the logs with a lot of these
       logger.warn(
           "truncated {} property value to {} characters (this message will only be logged once"

test/smoke/appServers/Wildfly.11/wildfly11.linux.partial.dockerfile

@@ -13,7 +13,7 @@ RUN if type "apt-get" > /dev/null; then \
 ENV WILDFLY_FULL_VERSION 11.0.0.Final
 
 # install tomcat
-RUN wget http://download.jboss.org/wildfly/$WILDFLY_FULL_VERSION/wildfly-$WILDFLY_FULL_VERSION.tar.gz \
+RUN wget https://download.jboss.org/wildfly/$WILDFLY_FULL_VERSION/wildfly-$WILDFLY_FULL_VERSION.tar.gz \
     && tar xzvf wildfly-$WILDFLY_FULL_VERSION.tar.gz \
     && mv ./wildfly-$WILDFLY_FULL_VERSION /opt/wildfly-$WILDFLY_FULL_VERSION
 

test/smoke/framework/testCore/src/main/java/com/microsoft/applicationinsights/smoketest/AiSmokeTest.java

@@ -403,7 +403,11 @@ protected static void waitForApplicationToStart() throws Exception {
       System.out.println("Test app health check complete.");
       waitForHealthCheckTelemetryIfNeeded(contextRootUrl);
     } catch (Exception e) {
-      AiDockerClient.printContainerLogs(containerInfo.getContainerId());
+      for (ContainerInfo container : allContainers) {
+        System.out.println("========== dumping container log: " + container.getContainerId());
+        AiDockerClient.printContainerLogs(containerInfo.getContainerId());
+        System.out.println("end of container log ==========");
+      }
       throw e;
     } finally {
       mockedIngestion.resetData();