Skip to content

Commit cecc10a

Browse files
committed
Fix CodeQL warnings
1 parent ccfffb3 commit cecc10a

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

etw/etw-testapp/src/main/java/com/microsoft/applicationinsights/etw_testapp/EtwTestController.java

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
package com.microsoft.applicationinsights.etw_testapp;
22

3+
import com.microsoft.applicationinsights.agent.internal.diagnostics.etw.DiagnosticsLoggerProxy;
4+
import java.util.concurrent.atomic.AtomicInteger;
35
import org.springframework.http.ResponseEntity;
46
import org.springframework.web.bind.annotation.GetMapping;
57
import org.springframework.web.bind.annotation.PathVariable;
68
import org.springframework.web.bind.annotation.RequestParam;
79
import org.springframework.web.bind.annotation.RestController;
810

9-
import java.util.concurrent.atomic.AtomicInteger;
10-
11-
import com.microsoft.applicationinsights.agent.internal.diagnostics.etw.DiagnosticsLoggerProxy;
12-
1311
@RestController
1412
public class EtwTestController {
1513
private static final DiagnosticsLoggerProxy DIAGNOSTICS_LOGGER = new DiagnosticsLoggerProxy();
@@ -51,7 +49,6 @@ public ResponseEntity<String> logPage(
5149
default:
5250
return ResponseEntity.notFound().build();
5351
}
54-
return ResponseEntity.ok(
55-
level.toUpperCase() + " " + n + (t == null ? "" : "<br/>\n" + t.toString()));
52+
return ResponseEntity.ok();
5653
}
5754
}

etw/etw-testapp/src/main/java/com/microsoft/applicationinsights/etw_testapp/LongTestController.java

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.microsoft.applicationinsights.etw_testapp;
22

3+
import com.microsoft.applicationinsights.agent.internal.diagnostics.etw.DiagnosticsLoggerProxy;
34
import java.math.BigInteger;
45
import java.text.SimpleDateFormat;
56
import java.time.Duration;
@@ -11,9 +12,6 @@
1112
import java.util.concurrent.atomic.AtomicLong;
1213
import java.util.concurrent.atomic.AtomicReference;
1314
import java.util.function.BinaryOperator;
14-
15-
import com.microsoft.applicationinsights.agent.internal.diagnostics.etw.DiagnosticsLoggerProxy;
16-
1715
import org.apache.commons.lang3.RandomUtils;
1816
import org.apache.commons.lang3.exception.ExceptionUtils;
1917
import org.springframework.beans.factory.annotation.Autowired;
@@ -246,14 +244,7 @@ public ResponseEntity<String> startTest(
246244
period = Duration.parse("PT" + periodStr);
247245
}
248246
} catch (NumberFormatException | DateTimeParseException e) {
249-
return ResponseEntity.badRequest()
250-
.body(
251-
"<p>Period parameter 'T' could not parse \""
252-
+ periodStr
253-
+ "\"</p>"
254-
+ "<p><pre>"
255-
+ ExceptionUtils.getStackTrace(e)
256-
+ "</p>");
247+
return ResponseEntity.badRequest().body("Period parameter could not be parsed");
257248
}
258249

259250
final long startTime;

0 commit comments

Comments
 (0)