extract method

Author: trask

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/AzureMonitorLogFilteringProcessor.java

@@ -16,7 +16,6 @@
 import io.opentelemetry.sdk.internal.AttributesMap;
 import io.opentelemetry.sdk.logs.LogRecordProcessor;
 import io.opentelemetry.sdk.logs.ReadWriteLogRecord;
-import io.opentelemetry.sdk.logs.export.BatchLogRecordProcessor;
 import io.opentelemetry.sdk.trace.ReadableSpan;
 import io.opentelemetry.sdk.trace.samplers.SamplingDecision;
 import io.opentelemetry.sdk.trace.samplers.SamplingResult;
@@ -39,14 +38,14 @@ public class AzureMonitorLogFilteringProcessor implements LogRecordProcessor {
 
   private final SamplingOverrides logSamplingOverrides;
   private final SamplingOverrides exceptionSamplingOverrides;
-  private final BatchLogRecordProcessor batchLogRecordProcessor;
+  private final LogRecordProcessor batchLogRecordProcessor;
 
   private volatile int severityThreshold;
 
   public AzureMonitorLogFilteringProcessor(
       List<Configuration.SamplingOverride> logSamplingOverrides,
       List<Configuration.SamplingOverride> exceptionSamplingOverrides,
-      BatchLogRecordProcessor batchLogRecordProcessor,
+      LogRecordProcessor batchLogRecordProcessor,
       int severityThreshold) {
 
     this.severityThreshold = severityThreshold;

agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java

@@ -262,29 +262,16 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
         .addPropertiesCustomizer(new AiConfigCustomizer())
         .addLogRecordProcessorCustomizer(
             (logRecordProcessor, configProperties) -> {
-              // filtering log record processors need to be chained on front of the batch log record
-              // processor, hopefully log filtering will be better supported by OpenTelemetry SDK in
-              // the future
-              // (e.g. https://github.com/open-telemetry/opentelemetry-specification/pull/4439)
               if (logRecordProcessor instanceof BatchLogRecordProcessor) {
                 List<LogRecordProcessor> logRecordProcessors =
                     getLogRecordProcessors(configuration);
-                List<Configuration.SamplingOverride> logSamplingOverrides =
-                    configuration.sampling.overrides.stream()
-                        .filter(override -> override.telemetryType == SamplingTelemetryType.TRACE)
-                        .collect(Collectors.toList());
-                List<Configuration.SamplingOverride> exceptionSamplingOverrides =
-                    configuration.sampling.overrides.stream()
-                        .filter(
-                            override -> override.telemetryType == SamplingTelemetryType.EXCEPTION)
-                        .collect(Collectors.toList());
 
+                // the filtering log record processor needs to be chained on front of the batch log
+                // record processor, hopefully log filtering will be better supported by
+                // OpenTelemetry SDK in the future, see
+                // https://github.com/open-telemetry/opentelemetry-specification/pull/4439
                 logFilteringProcessor =
-                    new AzureMonitorLogFilteringProcessor(
-                        logSamplingOverrides,
-                        exceptionSamplingOverrides,
-                        (BatchLogRecordProcessor) logRecordProcessor,
-                        configuration.instrumentation.logging.getSeverityThreshold());
+                    createLogFilteringProcessor(logRecordProcessor, configuration);
 
                 logRecordProcessors.add(logFilteringProcessor);
                 return LogRecordProcessor.composite(
@@ -335,6 +322,25 @@ public void customize(AutoConfigurationCustomizer autoConfiguration) {
         });
   }
 
+  private static AzureMonitorLogFilteringProcessor createLogFilteringProcessor(
+      LogRecordProcessor logRecordProcessor, Configuration configuration) {
+
+    List<Configuration.SamplingOverride> logSamplingOverrides =
+        configuration.sampling.overrides.stream()
+            .filter(override -> override.telemetryType == SamplingTelemetryType.TRACE)
+            .collect(Collectors.toList());
+    List<Configuration.SamplingOverride> exceptionSamplingOverrides =
+        configuration.sampling.overrides.stream()
+            .filter(override -> override.telemetryType == SamplingTelemetryType.EXCEPTION)
+            .collect(Collectors.toList());
+
+    return new AzureMonitorLogFilteringProcessor(
+        logSamplingOverrides,
+        exceptionSamplingOverrides,
+        logRecordProcessor,
+        configuration.instrumentation.logging.getSeverityThreshold());
+  }
+
   private static SpanExporter buildTraceExporter(
       Configuration configuration, TelemetryClient telemetryClient, QuickPulse quickPulse) {
     List<Configuration.SamplingOverride> exceptionSamplingOverrides =