Add comment

trask · trask · commit fad6c098edd1 · 2020-12-22T12:05:48.000-08:00
diff --git a/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/BeforeAgentInstaller.java b/agent/agent-tooling/src/main/java/com/microsoft/applicationinsights/agent/internal/BeforeAgentInstaller.java
@@ -121,6 +121,7 @@ private static void start(Instrumentation instrumentation) throws Exception {
         properties.put("experimental.log.capture.threshold", getLoggingFrameworksThreshold(config, "INFO"));
         int reportingIntervalSeconds = getMicrometerReportingIntervalSeconds(config, 60);
         properties.put("micrometer.step.millis", Long.toString(SECONDS.toMillis(reportingIntervalSeconds)));
+        // TODO need some kind of test for these configuration properties
         if (!isInstrumentationEnabled(config, "micrometer")) {
             properties.put("otel.instrumentation.micrometer.enabled", "false");
         }

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,7 @@ private static void start(Instrumentation instrumentation) throws Exception {`
`121`	`121`	`properties.put("experimental.log.capture.threshold", getLoggingFrameworksThreshold(config, "INFO"));`
`122`	`122`	`int reportingIntervalSeconds = getMicrometerReportingIntervalSeconds(config, 60);`
`123`	`123`	`properties.put("micrometer.step.millis", Long.toString(SECONDS.toMillis(reportingIntervalSeconds)));`
	`124`	`+ // TODO need some kind of test for these configuration properties`
`124`	`125`	`if (!isInstrumentationEnabled(config, "micrometer")) {`
`125`	`126`	`properties.put("otel.instrumentation.micrometer.enabled", "false");`
`126`	`127`	`}`