Update Java versions for tests #3878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
harsimar,
heyams,
jeanbisutti and
ramthi
as code owners
trask
force-pushed
the
update-test-versions
branch
from
cc48e2c to
64d5d6b
Compare
Member
|
cc @johnoliver |
trask
force-pushed
the
update-test-versions
branch
from
64d5d6b to
1367556
Compare
Member
Author
|
@johnoliver @dsgrieve I disabled the G1 test on Java 21+ so that we can merge this and make sure at least our other tests are passing on 21 and 23 |
trask
force-pushed
the
update-test-versions
branch
from
1367556 to
6bad36c
Compare
heyams
reviewed
Oct 23, 2024
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.junit.jupiter.api.condition.JRE.JAVA_11; | ||
| import static org.junit.jupiter.api.condition.JRE.JAVA_13; | ||
| import static org.junit.jupiter.api.condition.JRE.JAVA_17; |
Contributor
There was a problem hiding this comment.
does it need java 21 and java 23 test here since you added java 17?
Member
Author
There was a problem hiding this comment.
this import is for an exclusion, see below:
@EnabledForJreRange(max = JAVA_17)
jeanbisutti
approved these changes
Oct 24, 2024
| } | ||
|
|
||
| @Test | ||
| @EnabledForJreRange(max = JAVA_17) |
Member
There was a problem hiding this comment.
Suggested change
| @EnabledForJreRange(max = JAVA_17) | |
| @EnabledForJreRange(max = JAVA_17) // see https://github.com/microsoft/ApplicationInsights-Java/pull/3878#issuecomment-2431980712 |
Member
Author
There was a problem hiding this comment.
I'm going to merge so I don't have to wait for another CI build, but will send a quick follow-up to add this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently blocked on test failures inVariousCollectorsTestDisabled the G1 test for now on Java 21+