Skip to content

Update Java versions for tests #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Update Java versions for tests #3878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb7670b
Update Java versions for tests
trask Sep 24, 2024
05556ec
22 -> 23
trask Sep 24, 2024
6bad36c
Disable G1 test on 21+
trask Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ jobs:
- 8
- 11
- 17
- 18
- 21
- 23
vm:
- hotspot
# TODO (trask) enable once profiler supports OpenJ9
Expand Down
4 changes: 3 additions & 1 deletion ...or/gc-monitor-tests/src/test/java/com/microsoft/gcmonitortests/VariousCollectorsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.condition.JRE.JAVA_11;
import static org.junit.jupiter.api.condition.JRE.JAVA_13;
import static org.junit.jupiter.api.condition.JRE.JAVA_17;
Copy link
Contributor

@heyams heyams Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need java 21 and java 23 test here since you added java 17?

Copy link
Member Author

@trask trask Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this import is for an exclusion, see below:

@EnabledForJreRange(max = JAVA_17)

import static org.junit.jupiter.api.condition.OS.LINUX;

import com.microsoft.gcmonitor.GcCollectionEvent;
Expand Down Expand Up @@ -33,6 +34,7 @@ void testParallel() throws Exception {
}

@Test
@EnabledForJreRange(max = JAVA_17)
Copy link
Member

@jeanbisutti jeanbisutti Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@EnabledForJreRange(max = JAVA_17)
@EnabledForJreRange(max = JAVA_17) // see https://github.com/microsoft/ApplicationInsights-Java/pull/3878#issuecomment-2431980712

Copy link
Member Author

@trask trask Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge so I don't have to wait for another CI build, but will send a quick follow-up to add this comment

void testG1() throws Exception {
testGc("-XX:+UseG1GC", 50);
}
Expand All @@ -42,7 +44,7 @@ void testSerial() throws Exception {
testGc("-XX:+UseSerialGC", 50);
}

@Disabled
@Disabled // see https://github.com/microsoft/ApplicationInsights-Java/pull/3083
@Test
@EnabledForJreRange(min = JAVA_11)
void testShenandoah() throws Exception {
Expand Down
Loading