Migrate profiler code from jackson json to azure json #3896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@johnoliver |
Member
That was previously used at: But your updates have probably made that module redundant, so can be removed |
…com/microsoft/ApplicationInsights-Java into heya/migrate-profiler-to-azure-json
heyams
requested review from
harsimar,
jeanbisutti,
johnoliver,
ramthi and
trask
as code owners
johnoliver
approved these changes
Oct 22, 2024
trask
reviewed
Oct 22, 2024
.../microsoft/applicationinsights/diagnostics/appinsights/CodeOptimizerDiagnosticEngineJfr.java
Outdated
Show resolved
Hide resolved
...ft/applicationinsights/agent/internal/profiler/triggers/RequestAlertPipelineBuilderTest.java
Outdated
Show resolved
Hide resolved
heyams
commented
Oct 22, 2024
...alerting-api/src/main/java/com/microsoft/applicationinsights/alerting/alert/AlertBreach.java
Show resolved
Hide resolved
trask
reviewed
Oct 22, 2024
...gnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java
Show resolved
Hide resolved
...gnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/CGroupData.java
Outdated
Show resolved
Hide resolved
...ft/applicationinsights/agent/internal/profiler/triggers/RequestAlertPipelineBuilderTest.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Oct 23, 2024
...ostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/MachineStats.java
Outdated
Show resolved
Hide resolved
...agnostics-jfr/src/main/java/com/microsoft/applicationinsights/diagnostics/jfr/Telemetry.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Nov 10, 2024
Member
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
thanks @johnoliver for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.