Skip to content

Don't log Log Records if they are sampled out #3936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

Don't log Log Records if they are sampled out #3936

merged 2 commits into from
Nov 13, 2024

Conversation

@trask
Copy link
Member

@trask trask commented Oct 25, 2024 •
edited
Loading

@trask trask changed the title Move comment Move debug log location Oct 25, 2024
@trask trask changed the title Move debug log location Don't log Log Records if they are sampled out Oct 25, 2024
@trask trask mentioned this pull request Oct 29, 2024
Merged
@trask trask merged commit 88b28f6 into main Nov 13, 2024
90 checks passed
@trask trask deleted the move-comment branch November 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@heyams heyams Awaiting requested review from heyams

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@harsimar harsimar Awaiting requested review from harsimar harsimar is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trask @jeanbisutti