Skip to content

Debug JMX metrics #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Debug JMX metrics #4159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20c1710
Debug JMX metrics
jeanbisutti Apr 1, 2025
dafa695
empty check
jeanbisutti Apr 1, 2025
35ea82c
Log for custom JMX metrics
jeanbisutti Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .../com/microsoft/applicationinsights/agent/internal/init/PerformanceCounterInitializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ private static void calculateAndRecordValueForAttribute(
JmxDataFetcher.fetch(
objectName, jmxAttributeData.attribute); // should return the [val, ...] here

if (!result.isEmpty()) {
logger.info("Fetched JMX metrics: ", result);
}

logger.trace(
"Size of the JmxDataFetcher.fetch result: {}, for objectName:{} and metricName:{}",
result.size(),
Expand All @@ -209,6 +213,7 @@ private static void calculateAndRecordValueForAttribute(
value += Double.parseDouble(String.valueOf(obj));
}
} catch (RuntimeException e) {
logger.warn("Unexpected value from JMX: " + result, e);
ok = false;
break;
}
Expand Down
5 changes: 5 additions & 0 deletions ...crosoft/applicationinsights/agent/internal/perfcounter/AbstractJmxPerformanceCounter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ public synchronized void report(TelemetryClient telemetryClient) {
try {
Map<String, Collection<Object>> result = JmxDataFetcher.fetch(objectName, attributes);

if (!result.isEmpty()) {
logger.info("Fetched JMX metrics: ", result);
}

for (Map.Entry<String, Collection<Object>> displayAndValues : result.entrySet()) {
boolean ok = true;
double value = 0.0;
Expand All @@ -46,6 +50,7 @@ public synchronized void report(TelemetryClient telemetryClient) {
value += Double.parseDouble(String.valueOf(obj));
}
} catch (RuntimeException e) {
logger.warn("Unexpected value from JMX: " + displayAndValues, e);
ok = false;
break;
}
Expand Down
Loading